@see should not be used inside a @param description

For DateTimePlus class I provide this patch.

Thanks for the review. I resolved the problems mentioned by you.

Hi @purav

The patch you applied is missing the last change which was earlier asked to change form see to @see.

I am attaching the patch with corrected @see annotations from #3 with corrections of #4.

@shubhangi1995, Thanks for working on the issue. Patch should not be of .txt format.

sorry i guess i missed it @mohitmalik thanks for pointing it out.

re -uploaded the patch

@shubhangi1995, in the last part of patch #3, the change from from @see to See was not required so it was corrected in patch #5.

@@ -486,7 +486,7 @@ protected function prepareFormat($format) {
    * PHP creates a valid date from invalid data with only a warning,
    * 2011-02-30 becomes 2011-03-03, for instance, but we don't want that.
    *
-   * @see http://php.net/manual/time.getlasterrors.php
+   * See http://php.net/manual/time.getlasterrors.php

Patch #5 did changes correctly as per comment #4

@harsha012, The patch you submitted didn't fix all the @see to See

+++ b/core/lib/Drupal/Component/Datetime/DateTimePlus.php
@@ -212,9 +212,9 @@ public static function createFromTimestamp($timestamp, $timezone = NULL, $settin
    *   @see http://php.net/manual/datetime.createfromformat.php

This is still left to be fixed.

@shubhangi1995 Your patch #11 is failed to apply.

This patch will fix the above stated problem.

@ankitjain28may, patch serves the purpose and applies cleanly. RTBC good to go.

Thank you for your work on cleaning up Drupal core's code style!

In order to fix core coding standards in a maintainable way, all our coding standards issues should be done on a per-rule basis across all of core, rather than fixing standards in individual modules or files. We should also separate fixes where we need to write new documentation from fixes where we need to correct existing standards. This all should be done as part of #2571965: [meta] Fix PHP coding standards in core, stage 1. A good place to start is the child issues of #2572645: [Meta] Fix 'Drupal.Commenting.FunctionComment' coding standard.

For background information on why we usually will not commit coding standards fixes that aren't scoped in that way, see the core issue scope guidelines, especially the note about coding standards cleanups. That document also includes numerous suggestions for scoping issues including documentation coding standards cleanups.

Contributing to the overall plan above will help ensure that your fixes for core's coding standards remain in core the long term.

I am able to apply patch for 8.6.x version. But I am not able to apply patch for 8.9.x

$ git apply -v see-should-not-be-used-inside-param-2940420-19.patch
Checking patch core/lib/Drupal/Component/Datetime/DateTimePlus.php...
error: while searching for:
* @param \DateTime $datetime
* A DateTime object.
* @param array $settings
* @see __construct()
*
* @return static
* A new DateTimePlus object.

error: patch failed: core/lib/Drupal/Component/Datetime/DateTimePlus.php:129
error: core/lib/Drupal/Component/Datetime/DateTimePlus.php: patch does not apply

Hello @Neslee Canil Pinto

I cant see any difference between patch 19 and patch 26.
Your patch got failed.

KIndly review updated patch.

This needs work for the point raised by alexpott in #22 which makes this not a novice issue anymore.

This was fixed as part of #2933424: English-specific links to php.net shouldn't be used in non-translatable strings. Closing as a duplicate.