Followup to #2875394: Replace all calls to db_query, which is deprecated

CommentFileSizeAuthor
#8 interdiff-2939385-02-08.txt1.06 KBvoleger
#8 replace_all_db_query_calls-2939385-08-8.6.x.patch685 bytesvoleger
#2 replace_all_db_query_calls-2939385-02-8.6.x.patch1.25 KBvoleger

Comments

voleger created an issue. See original summary.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
StatusFileSize
new replace_all_db_query_calls-2939385-02-8.6.x.patch1.25 KB
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Active » Needs review
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Assigned: voleger » Unassigned
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Needs work 
+++ b/core/includes/database.inc
@@ -390,7 +390,7 @@ function db_escape_field($field) {
- * all supported database systems. Using db_like() with db_query() or
+ * all supported database systems. Using db_like() with \Drupal::database()->query() or

This comment should be rewritten to be < 80 cols wide.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/core/includes/database.inc
@@ -390,7 +390,7 @@ function db_escape_field($field) {
  *
  * You must use a query builder like db_select() in order to use db_like() on
- * all supported database systems. Using db_like() with db_query() or
+ * all supported database systems. Using db_like() with \Drupal::database()->query() or
  * db_query_range() is not supported.

pretty sure the other functions are also deprecated *and* this itelf documentation on a deprecated function, so not sure if we really want to touch this?

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented

#6 I guess you are right. #2849745: Replace documentation recommending db_*() wrappers exists, and change documentation on deprecated function is not a good idea.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Needs work » Needs review
StatusFileSize
new replace_all_db_query_calls-2939385-08-8.6.x.patch685 bytes
new interdiff-2939385-02-08.txt1.06 KB
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Needs review » Closed (duplicate)

duplicated because of #2849745: Replace documentation recommending db_*() wrappers
so there no replacements in core/include in this scope.