Use route match in umami_preprocess_breadcrumb instead of accessing raw request parameters

+++ b/core/profiles/demo_umami/themes/umami/umami.theme
@@ -63,7 +63,7 @@ function umami_preprocess_breadcrumb(&$variables) {
   $request = \Drupal::request();

not needed anymore?

for #3

LGTM

I looked into the logic, and route will always exist, so I think we can clean it up a bit more

We should also fix #2904243-64: Implement the Out of the Box designs as a theme for demo_umami item 2 and 3 too.

Something like this?

/**
 * Implements hook_preprocess_breadcrumb().
 */
function umami_preprocess_breadcrumb(&$variables) {
  $request = \Drupal::request();
  // Search page titles aren't resolved using the title_resolver service - it
  // will always return 'Search' instead of 'Search for [term]', which would
  // give us a breadcrumb of Home >> Search >> Search.
  // @todo Revisit after https://www.drupal.org/project/drupal/issues/2359901
  // @todo Revisit after https://www.drupal.org/project/drupal/issues/2403359
  if (($entity = $request->attributes->get('entity')) && $entity->getEntityTypeId() === 'search_page') {
    $variables['current_page_title'] = $entity->getPlugin()->suggestedTitle();
  }
  else {
    $variables['current_page_title'] = \Drupal::service('title_resolver')->getTitle($request, \Drupal::routeMatch()->getRouteObject());
  }
  // Since we are printing the 'Current Page Title', add the URL cache context.
  // If we don't, then we might end up with something like
  // "Home > Articles" on the Recipes page, which should read "Home > Recipes".
  $variables['#cache']['contexts'][] = 'url';
}

if (($entity = $request->attributes->get('entity')) && $entity->getEntityTypeId() === 'search_page') {

$entity = $route_match->getParameter('entity');
if ($entity instanceof SearchPageInterface) {

@navneet0693: This LGTM.
This does cover #2904243-64: Implement the Out of the Box designs as a theme for demo_umami 2 & 3. 👍🏻

It addresses 64.1, yes
But it completely ignores 64.2 and 64.3

@tim.plunkett: Sorry, I totally misunderstood it previously.
I have few questions here wrt to 64.2 & 64.3.
64.2: Default core doesn't print current title. Thus we need a hook to add. (I couldn't find it, maybe I'm missing something here).
64.2: Agree here, we should write specifics in their respective modules. But, this is implemented for the demo_umami profile, thus it won't be a good idea to override search module for this specific purpose.

This change is still required and the patch looks good. Would be great for someone to A/B test all pages to make sure no behaviour is changed at Drupal Europe.

Rerolling a new patch since the old one didn't apply anymore (it got old).

Interdiff fails to create something for me, I am attaching a plain diff.

I can't see any visual regressions before and after patch 20 (same as patch 10).

Code looks good to me and it has been manually tested, as well. Thanks!

The patch in #20 is applicable.

$ curl https://www.drupal.org/files/issues/2018-09-14/2937898_20.patch | git apply
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2490  100  2490    0     0   9726      0 --:--:-- --:--:-- --:--:--  9726

I tested it manually and I can confirm that there is no visual regression as mentioned in #20.

Committed e432b65 and pushed to 8.7.x. Thanks!