Problem/Motivation

Currently workflow type key is integer and it's hard to get the type from it:

Proposed resolution

use machine name.

Remaining tasks

Discuss

User interface changes

No

API changes

TBC

Data model changes

TBC

CommentFileSizeAuthor
#3 Screen Shot 2017-09-29 at 2.33.10 pm.png183.63 KBsam152
workflow-type-key.png342.6 KBvijaycs85

Comments

vijaycs85 created an issue. See original summary.

manuel garcia’s picture

manuel garcia commented
Issue tags: +Vienna2017
sam152’s picture

sam152 commented
StatusFileSize
new Screen Shot 2017-09-29 at 2.33.10 pm.png183.63 KB

I can't reproduce this:

vijaycs85’s picture

vijaycs85
Location London, UK
commented

wow, that looks interesting @Sam152. you can see the tests failing because of key issue on #2902018: Use array_column instead of array_map where possible in the Workflows module. Probably I am missing some settings? I have just workflows and content_moderation enabled on a 8.5.x.

sam152’s picture

sam152 commented

Let me try reinstall on HEAD and enable content moderation. You don't have the patch from #2902018: Use array_column instead of array_map where possible in the Workflows module actually applied? Because HEAD is green and I think there are tests for clicking through and creating a moderation workflow from the UI.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Closed (won't fix)

@Sam152: you are right. it was the patch in #2902018: Use array_column instead of array_map where possible in the Workflows module that's killing key. I am closing this issue. thanks both!