Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
When you have an ajax link within dropbuttons, the throbber jumps to the next line
This was found out during #2830584: Use modals for creating, updating, and deleting workflows, with a new DialogFormTrait, and it was decided to split that part of the patch into its own issue.
See the bug:
Proposed resolution
Fix it in dropbutton.component.css
Remaining tasks
Do it
User interface changes
None (UI bug prevented)
API changes
None
Data model changes
None
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2909882-2.patch | 793 bytes | manuel garcia |
Comments
Comment #2
manuel garcia commentedAttaching patch split off of #2830584: Use modals for creating, updating, and deleting workflows, with a new DialogFormTrait
This is how the throbbers looks with the patch:
Comment #3
timmillwoodI think this is a hard one to test, and until #2830584: Use modals for creating, updating, and deleting workflows, with a new DialogFormTrait lands I don't think there are any throbblers on drop buttons in core, but it fixes the issue.
Comment #4
xjmThanks @timmillwood!
I have actually seen this before somewhere in core, not sure where. Probably the Views UI or something. In any case, tagging for the frontend committers.
Comment #5
timmillwoodThanks to @Manuel Garcia!
Views uses a full-screen throbber, as added in #2207695: Expand the throbber API to include a 'full screen' option, from what I can see. Although we'll soon have somewhere in core doing it, when #2830584: Use modals for creating, updating, and deleting workflows, with a new DialogFormTrait gets in. ;)
Comment #6
yoroy commentedI tested this on simplytest, using this patch and the one in #2830584: Use modals for creating, updating, and deleting workflows, with a new DialogFormTrait. The throbber stays on the same line now, so looks good to me!
Comment #7
yoroy commentedOpened #2914519: Update the design for "loading…" buttons that show a spinner animation as a followup to improve the design of this thing.
Comment #10
lauriiiRemoved on the commit the px from the 0 value.
Committed 0540b0e and pushed to 8.5.x. Thanks!
Comment #12
idebr commentedThis change causes the ajax progress content to be displayed on top of other content. This becomes very apparent when working with the Paragraphs module:
I suggest this change is reverted until we have determined a solution that works for all ajax progress indicators.
I have also filed a bug report at #2935593: Ajax progress throbber displays on top of other content
Comment #13
lauriii