Follow-up to #2853872: Migration for forum and article comments: duplicate comment types and incorrect comment_entity_statistics

Problem/Motivation

I migrated my D6 site to Drupal 8. When migrating forum content, I noticed that the Replies and Last reply columns of the forum thread list view are not taking the migrated comments into account.

This was found in #2853872-98: Migration for forum and article comments: duplicate comment types and incorrect comment_entity_statistics

Proposed resolution

  • Do not create comment types comment_node_forum and comment_node_article for forum and article content types because these content types already have the out of the box comment fields. Several comment / field migrations need to be updated.
  • Introduce a new process plugin skip_row_if_in_blacklist which allows us to skip comment_node_forum and comment_node_article rows in these migrations.
  • Use static_map process plugin to map the D7 comment / field migrations to the D8 standard comment_forum and comment comment types
  • Remark: the third standard D8 content type Page does not have any comment fields by default so that is not suffering from this issue. No actions required for Page content type.

Remaining tasks

  • write patch
  • review it

User interface changes

None.

API changes

None.

Data model changes

None.

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Related issues: +#2905491: Mark Migrate Drupal UI as stable
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Related issues: -#2905491: Mark Migrate Drupal UI as stable +#2905736: Mark Migrate Drupal as stable
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Priority: Major » Critical
Status: Active » Postponed

Postponing on #2853872: Migration for forum and article comments: duplicate comment types and incorrect comment_entity_statistics so that the discussion isn't fragmented as we finalize the approach.

Per discussion with @catch, we're promoting the "Migrate critical" issues to critical given the importance of a stable migration path at this point in the release cycle. (The framework and release managers will confirm this in a later triage for individual issues.)

edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
CreditAttribution: edysmp at MTech, LLC commented

Related issue?: #2887142: NodeType source plugin should include comment information

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented

@edysmp it is related, but not a blocker. See #2853872-115: Migration for forum and article comments: duplicate comment types and incorrect comment_entity_statistics.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Postponed » Active

This is a blocker for fixing: #2887142: NodeType source plugin should include comment information. And it is no longer blocked.

maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer commented
Status: Active » Closed (duplicate)

Re #7: In fact it's the other way around, this issue needed #2887142: NodeType source plugin should include comment information to be resolved. The reason is that right now the D6 to D8 migration only creates 2 comment types (comment & comment_no_subject). To be able to correctly map the forum comment type, we first need to create one comment type per node type.

Since this mapping for the forum comment type only requires a few lines, I went ahead and made the changes in #2887142: NodeType source plugin should include comment information, which is already RTBC, so we can now close this issue as a duplicate.