Problem/Motivation

Mark module as fully stable. This is pended while child issues are being worked.

Proposed resolution

  • Consider migrate_drupal.module stable as of 8.6.0. The expectations for beta experimental modules are:
    • Beta experimental modules are considered API- and feature-complete. Some early adopters may begin using beta experimental modules on development sites, but should be aware that they are not yet fully supported and may contain bugs.
    • Developers can begin using beta modules' APIs, but should be aware that some things may still change to address bugs. Beta modules are subject to the beta allowed changes policy.
    • An upgrade path may be provided from beta versions, but be aware it may contain critical bugs.

    For RC:

    Release candidate (e.g. 8.y.x-rc)

    Release candidate (RC) experimental modules are essentially stable and may be release-ready, although some changes might be made to address critical bugs.
    RC modules are subject to the RC allowed changes policy.
    Upgrade paths are provided from release candidate versions.

    And for fully stable:

    Stable core modules
    Once an experimental module is judged stable, the module will be moved out of the Core (Experimental) package, and its version number and allowed changes will be the same as Drupal core's. Experimental modules may only become stable modules in minor or major releases. Not all experimental modules will necessarily become stable core modules.

Remaining tasks

See
Migrate criticals

Approvals

Needs signoff from Migrate maintainers and framework and release managers.

  • Migrate maintainer - Adam Globus-Hoenich (phenaproxima) - Approved (#12)
  • Migrate maintainer - Lucas Hedding (heddn) - Approved
  • Migrate maintainer - Markus Sipilä (masipila) - Approved in #18
  • Migrate maintainer - Vicki Spagnolo (quietone) - ???
  • Migrate maintainer - Maxime Turcotte (maxocub) - Approved #16
  • Framework manager - ???
  • Release manager - ???
CommentFileSizeAuthor
#15 2905736-15.patch481 bytesheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Issue summary: View changes
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Issue summary: View changes

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Title: [policy, no patch] Mark Migrate Drupal as beta » [policy, no patch] Mark Migrate Drupal as stable
Version: 8.5.x-dev » 8.6.x-dev
Issue summary: View changes

For perspective, this is currently only blocked by #2953360: Experimental migrate_drupal_multilingual module.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Issue tags: +Needs product manager review, +Needs framework manager review

In today's migrate maintainers meeting, we discussed #2953360: Experimental migrate_drupal_multilingual module and whether it is needed. There are many incomplete i18n upgrade paths. The main one being #2073467: Migrate Drupal 7 Entity Translation settings to Drupal 8. If we determine we can fix it and any other upgrade paths without BC breaks, can migrate drupal be marked stable? Even if we have missing paths but a stable API?

Tagging to get product manager and/or framework manager feedback.

masipila’s picture

masipila commented

We had a lengthy discussion on the i18n upgrade path in today's migrate maintainers meeting like @heddn wrote above.

The summary of the discussion is as follows:

  • We consider migrate_drupal to be stable for non-multilingual sites already now
  • But we acknolewdge that the upgrade path for multilingual sites is not complete yet
  • The first release where migrate_drupal can be marked stable is 8.6.0
  • 8.6.0 Feature Freeze is on the week of July 18, 2018 which means that we have about 8 weeks left to that
  • If we can land the 'most important i18n upgrade issues' before that, then the discussion about the discussion for the experimental migrate_drupal_i18n module is irrelevant because we can declare migrate_drupal stable also for multilingual sites
  • If we can't land the 'most important i18 upgrade issues' before 8.6.0, then we need Product Manager / Framework Manager judgement call if we want to mark drupal_migrate stable but migrate_drupal_i18n as still experimental.

Next steps:

  • The remaining i18n upgrade issues are tagged with i18n-migrate
  • Let's triage these issues from two aspects:
  • a) Do we consider them to be needed for declaring migrate_drupal stable for multilingual sites
  • b) Do we spot any issues that might break BC
  • Based on this triage exercise, we can get a backlog of those issues that block declaring migrate_drupal as stable also for multilingual sites.

Agreed tagging:

  • All i18n upgrade issues must have the 'i18n-migrate' tag
  • Issues that are blocking migrate_drupal from being stable for multilingual sites must also be tagged as 'Migrate Critical' and 'Migrate Drupal'

I'll try to go through the remaining i18n-migrate issues by the end of this week and do my part of the triaging.

Cheers,
Markus

Edit: formatting

catch’s picture

catch
he/him
Primary language English
commented

I need to discuss this with other committers, but my general feeling is that something like #2073467: Migrate Drupal 7 Entity Translation settings to Drupal 8 should block stability, but that something like #2961114: Migrate D6 i18n CCK field option translations should not.

Entities and configuration dependencies for entities we absolutely need a reliable migration path for, but specific configuration translations, while it's great to provide support for it, they would always have required a contrib upgrade path in the past. Multilingual sites will need to do some additional interface translation after migration anyway because there are new strings.

masipila’s picture

masipila commented

I went through the list of currently known i18n related migrate issues. See #56 of #2208401: [META] Remaining multilingual migration paths.

Let's continue the triaging in that issue.

Markus

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -Needs framework manager review +Needs release manager review

Agree with catch in #8. I think this is more in need of product and release feedback in fact, not framework. @catch started to provide that feedback but needs more committer input. My committer input is IMHO we need to cover configuration where it is critical for settings of content so that content is not lost or unintentionally removed without the config being adjusted first. So long as the missing config translation is just missing, that is easier to get over.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue summary: View changes

#2953360: Experimental migrate_drupal_multilingual module has landed, which officially makes all translation migrations experimental, since they all depend on an experimental module.

People have been able to successfully migrate monolingual sites to Drupal 8 for a while now using Migrate Drupal. There are obviously still some small problems here and there, but overall it seems to work pretty well. Data loss issues, as always, are considered critical -- which is line with what goes on in stable core.

So, I'm in favor of this distinction. +1, and congratulations to us all!

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Title: [policy, no patch] Mark Migrate Drupal as stable » Mark Migrate Drupal as stable
Category: Plan » Task
Issue summary: View changes
Status: Postponed » Needs review

Based off the last time we did this, it was more awkward to do this as two issues. So switching this to a task and active.

Do we still need release and produce manager reviews?

I'm +1 on marking stable.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Active
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Version: 8.7.x-dev » 8.6.x-dev
Status: Active » Needs review
StatusFileSize
new 2905736-15.patch481 bytes

And here's a patch.

maxocub’s picture

maxocub commented

+1 for stability

maxocub’s picture

maxocub commented
Issue summary: View changes

Updated the IS.

masipila’s picture

masipila commented
Issue summary: View changes

Remaining criticals are all related to multilingual sites. I'm +1 for declaring Migrate Drupal stable now that we have experimental #2953360: Experimental migrate_drupal_multilingual module.

quietone’s picture

quietone commented

Yes, all for stable. All the reasons are well stated above.

+1

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

And, we're RTBC. Let's do it.

  • catch committed dbd37f5 on 8.7.x 
    Issue #2905736 by heddn: Mark Migrate Drupal as stable

  • catch committed 80d7332 on 8.6.x 
    Issue #2905736 by heddn: Mark Migrate Drupal as stable

(cherry picked...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs product manager review, -Needs release manager review

This still has the tags on it, but all the product/release review was done on the experimental multilingual issues and etc.

Really good to get to this point!

Committed/pushed to 8.7.x and cherry-picked to 8.6.x. Thanks!

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented
Issue tags: +8.6.0 highlights

That's a pretty big deal. Congratulations!

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

Congrats all around. High-fives!!! How many years in the making? Almost 5 me thinks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.