Split from #2835767-61: Media + REST: comprehensive test coverage for Media + MediaType entity types.

@Wim Leers:

Media specifies a add-page link relation in its annotation, but that link relation type doesn't exist — added that link relation type.

CommentFileSizeAuthor
#4 2905720-4.patch1.71 KBAnonymous (not verified)
#4 2905720-4-test-only.patch1.1 KBAnonymous (not verified)
#2 2905720-2-interdiff.txt626 bytesAnonymous (not verified)
#2 2905720-2.patch1.71 KBAnonymous (not verified)
#2 2905720-2-test-only.patch1.14 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented

vaplas created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
Issue tags: +blocker
Related issues: +#2835767: Media + REST: comprehensive test coverage for Media + MediaType entity types
StatusFileSize
new 2905720-2-test-only.patch1.14 KB
new 2905720-2.patch1.71 KB
new 2905720-2-interdiff.txt626 bytes

I copied the idea of checking from Drupal\rest\Plugin\rest\resource\EntityResource and Drupal\KernelTests\Core\Http\LinkRelationsTest. Also, please add a credit to @Wim Leers, who found this bug and provided a fix and a test in #2835767-46: Media + REST: comprehensive test coverage for Media + MediaType entity types.

Added tag 'blocker', because #2835767: Media + REST: comprehensive test coverage for Media + MediaType entity types.

The last submitted patch, 2: 2905720-2-test-only.patch, failed testing. View results

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new 2905720-4-test-only.patch1.1 KB
new 2905720-4.patch1.71 KB

Sorry, incorrect test-only patch (without "new file mode 100644"). Reupload both patches (to save NR status).

The last submitted patch, 4: 2905720-4-test-only.patch, failed testing. View results

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
Status: Needs review » Reviewed & tested by the community

Looks good! Thanks.

  • larowlan committed 8cec5c8 on 8.5.x 
    Issue #2905720 by vaplas: Media specifies a add-page link relation, but...

  • larowlan committed 9237a9e on 8.4.x 
    Issue #2905720 by vaplas: Media specifies a add-page link relation, but...

larowlan credited larowlan.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed as 8cec5c8 and pushed to 8.5.x.
Cherry-picked as 9237a9e and pushed to 8.4.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.