Follow-up to #2893978: Use newly supported 'options' in contextual links in Settings Tray contextual links
#2893978: Use newly supported 'options' in contextual links in Settings Tray contextual links implemented "options" in outside_in.links.contextual.yml but there is a quoted boolean and also some other unnecessary quoting in the yml. The quoted boolean results in some markup that's not quite right (the last attribute should be valueless, just data-outside-in-edit):
<a href="/admin/structure/block/manage/bartik_tools/off-canvas?destination=node" class="use-ajax" data-dialog-type="dialog" data-dialog-renderer="off_canvas" data-outside-in-edit="TRUE">Quick edit</a>
Update the data in outside_in.links.contextual.yml. Consider whether test coverage would make sense.
Patch
Not UI but a slight markup change.
n/a
n/a
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2899942-4.patch | 605 bytes | tedbow |
| #2 | 2899942-2.patch | 776 bytes | tedbow |
Comments
Comment #2
tedbowFixing
Comment #3
wim leersLots of unrelated changes?
Comment #4
tedbowre unrelated changes before I made the patch I looked at node.links.contextual.yml and saw nothing had quotes. I thought that was correct But now I look at others and that is not the case. block.links.contextual.yml has all quoted and menu_ui.links.contextual.yml has some quoted.
Removing changes unrelated to options.
Comment #5
wim leersComment #8
star-szrCommitted and pushed b9d6ef3974 to 8.5.x and 9d44ec4839 to 8.4.x. Thanks!
Comment #9
tedbowChanging to new settings_tray.module component. @drpal thanks for script help! :)