Use newly supported 'options' in contextual links in Settings Tray contextual links

Awesome!

RTBC++

Committed 0a42c06 and pushed to 8.5.x. Thanks!

+++ b/core/modules/outside_in/outside_in.links.contextual.yml
@@ -2,3 +2,9 @@ outside_in.block_configure:
+      data-dialog-type: 'dialog'
+      data-dialog-renderer: 'off_canvas'
+      data-outside-in-edit: 'TRUE'

Minor: I don't think any of these needed quotes. This isn't consistent in HEAD at all and I can't find a documented standard so more of a curiosity and not anything worth making a fuss over :) A quick search turned up #2124559: Figure out a standard for booleans in yaml files.

#11 great remark! Actually… I'm pretty sure that

+++ b/core/modules/outside_in/outside_in.links.contextual.yml
@@ -2,3 +2,9 @@ outside_in.block_configure:
+      data-outside-in-edit: 'TRUE'

This is wrong. This will result in <blah data-outside-in-edit="TRUE">, rather than <blah data-outside-in>. I think this may require a revert plus test coverage. Assigning to @tedbow for decision on that.

I should've noticed this, especially because I worked on the test coverage at #2892942: Contextual links support options but not use them to generate links that explicitly tests this! :( Sorry!

@Wim Leers ah yes you're right:

<a href="/admin/structure/block/manage/bartik_tools/off-canvas?destination=node" class="use-ajax" data-dialog-type="dialog" data-dialog-renderer="off_canvas" data-outside-in-edit="TRUE">Quick edit</a>

I think a follow-up issue would be fine, assuming that everything still works with the unneeded TRUE value.

This should also be committed to 8.4.x, actually.

@Wim Leers thank you :) 8.4.x was and is frozen for the first alpha but agreed this should go into 8.4.x when possible.

Yep! Hope this is the right status. Perhaps Patch (to be ported) is more accurate?

I don't have a preference.

Cherry-picked as cccc2d4 and pushed to 8.4.x. Thanks!

I created a follow-up to clean up the data types and discuss further: #2899942: Correct data types in outside_in.links.contextual.yml

Yay, thanks @Cottser!

Totally meant to add the relation, thank you @Wim Leers :)

Hah, np :)