Could the permissions be grouped per workflow type? It is now alphabetically sorted per state and this will be very hard to use with more workflow types. (See image.)

Permissions

CommentFileSizeAuthor
#6 CM_permissions_after.PNG19.64 KBneograph734
#4 group_content-2899306-4.patch2.33 KBneograph734
#2 group_content-2899306-2.patch1.03 KBneograph734

Comments

Neograph734 created an issue. See original summary.

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Active » Needs review
StatusFileSize
new group_content-2899306-2.patch1.03 KB

Inverted the pattern so permissions now look like this (to match other core modules):

Editorial workflow: Use Publish transition.

Status: Needs review » Needs work

The last submitted patch, 2: group_content-2899306-2.patch, failed testing. View results

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Needs work » Needs review
StatusFileSize
new group_content-2899306-4.patch2.33 KB

Updated the test

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Issue tags: +Workflow Initiative, +Needs screenshots

Awesome work @Neograph734, looking nice.

Great the permission ID hasn't changed so should be fully backwards compatible.

Might be worth showing a before/after screenshot for UX review.

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
StatusFileSize
new CM_permissions_after.PNG19.64 KB

Thanks @timmillwood :)

Here is a screenshot after the patch, grouped by workflow name (In my test setup Profiles was renamed to Article):

Permissions

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Issue tags: -Needs screenshots +Needs usability review

Thanks, lets see what the usability team think, then move to RTBC.

Bojhan’s picture

Bojhan commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs usability review

Mooooore overview on permissions, lets do it :)

Labeling wise this seems fine, and it makes sense to group this.

  • larowlan committed 517619e on 8.5.x 
    Issue #2899306 by Neograph734: Group content moderation permissions per...

  • larowlan committed da667d3 on 8.4.x 
    Issue #2899306 by Neograph734: Group content moderation permissions per...

larowlan credited larowlan.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed as 517619e and pushed to 8.5.x.

Cherry-picked as da667d3 and pushed to 8.4.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.