#2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method added comprehensive test coverage for entities.

We need the same for fields. Because #2751325: All serialized values are strings, should be integers/booleans when appropriate shows that even the most trivial improvement (a small bugfix) is impossible to land. We need more guarantees.

Comments

Wim Leers created an issue. See original summary.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Every field normalizer must have strict test coverage » Every normalizer must have strict test coverage
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Closed (works as designed)
Related issues: +#2751325: All serialized values are strings, should be integers/booleans when appropriate, +#2768651: Let TimestampItem (de)normalize to/from RFC3339 timestamps, not UNIX timestamps, for better DX, +#2824717: Add a format constraint to DateTimeItem to provide REST error message

I think the situation isn't as bad as I indicated in the issue summary.

Key normalizers like \Drupal\hal\Normalizer\ContentEntityNormalizer and \Drupal\serialization\Normalizer\EntityNormalizer, \Drupal\serialization\Normalizer\FieldItemNormalizer are abstract. Gazillions of variations are possible. It's impossible to completely unit test those normalizers. Hence the need for comprehensive functional tests, which test them for every possible entity type. That's what #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method already did.

Concrete field normalizers are getting strict test coverage:

So, closing this.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Closed (works as designed) » Closed (outdated)