Currently Drupal.behaviors.dialog.prepareDialogButtons only works on input elements or links styled as buttons. It does not account for the fact there may be button elements.

CommentFileSizeAuthor
#30 2822014-30.patch704 bytescasey
#29 2822014-29.patch616 bytescasey
#21 2822014-21.patch612 byteskksandr
#19 2822014-19.patch583 bytesseanb
#17 2822014-nr-bot.txt152 bytesneeds-review-queue-bot
#3 Home___ForkdIn_and_Home___ForkdIn.png218.67 KBmglaman
#2 preparedialogbuttons-2822014-2.patch696 bytesmglaman

Issue fork drupal-2822014

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new preparedialogbuttons-2822014-2.patch696 bytes

This can easily reproduced by using a theme which adds input--submit.html.twig and replaces the input with button tag.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Issue summary: View changes
StatusFileSize
new Home___ForkdIn_and_Home___ForkdIn.png218.67 KB

Attaching screenshot

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

luuph’s picture

luuph commented

Is there a reason why everything in .form-actions shouldn't be in that area? At first glance it seems like a logical place for all form actions.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 2822014-nr-bot.txt152 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
Status: Needs work » Needs review
StatusFileSize
new 2822014-19.patch583 bytes

Reroll for 10.1

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs tests

As a bug could we get a test case showing the issue?

kksandr’s picture

kksandr commented
StatusFileSize
new 2822014-21.patch612 bytes

The Claro theme converts the delete button from a.button to a.action-link (_claro_convert_link_to_action_link), I think they should also be moved to the action area.

jonmcl’s picture

jonmcl commented

I know it should probably be another issue, but if this issue ever manages to make it into core, it would be great if one small addition could be added:

          class: $originalButton.attr('class'),
          disabled: $originalButton.attr('disabled'),

allowing the dialog buttons to inherit the disabled attribute from the original button.

kksandr’s picture

kksandr commented
Related issues: +#3359240: Enable bundle selection when a new view mode is created

The issue with action links has been resolved here: https://www.drupal.org/project/drupal/issues/3359240

kksandr opened merge request !5856

kksandr’s picture

kksandr commented

I moved the fix from patches to the merge request

sourabhjain’s picture

sourabhjain
Primary language English
commented

Let me work on suggestion #22.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

@sourabhjain That suggestion needs a separate issue. All issues should focus on only fixing one specific thing, you should know that by now. Please revert, and if you're feeling like it, create a child issue for that.

sourabhjain’s picture

sourabhjain
Primary language English
commented

Sure @bramdriesen. Let me revert it.

casey’s picture

casey commented
StatusFileSize
new 2822014-29.patch616 bytes

Reroll for 10.2

casey’s picture

casey commented
StatusFileSize
new 2822014-30.patch704 bytes

Snapshot of latest state of MR (after rebase) for safe usage with composer patches

oily’s picture

oily commented

The broken functional test looked unrelated. Re-ran the pipeline once or twice and now it is green.

Test coverage still required.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.