Convert AJAX part of \Drupal\system\Tests\Ajax\ElementValidationTest::testAjaxElementValidation to JavascriptTestBase

The solution to this conversion exists in this issue.

#2862510: Convert system/tests/src/Ajax to JavascriptTestBase

but by common consent that issue is being shipwrecked -- broken up for parts and spares.

In this patch I am cutting out the conversion specific to ElementValidationTest

This shipwrecking has to be coordinated... the issue below, which is in review, is creating a AjaxTestBase class which this sub-putach assumes in already in core. Therefore I am postponing this issue with the solution almost working.

#2809521: Convert AJAX part of \Drupal\system\Tests\Ajax\AjaxInGroupTest to WebDriverTestBase

The AjaxTestBase class was scuttled (in keeping with the maritime theme here), in #2809521: Convert AJAX part of \Drupal\system\Tests\Ajax\AjaxInGroupTest to WebDriverTestBase, so no need to wait for that anymore

Thanks for taking the time to dig through old issues and see that...

Lendude++

The patch needed a reroll... but the patch was so old and the changes so small... that I just started again.

Hmm .. that passes locally. I will look into it.

I have just checked again today. Regarding 2809529-9.patch

I should qualify what I mean by works for me. I'm on PHP 7.2.9

So

composer run-script drupal-phpunit-upgrade

php core/scripts/run-tests.sh --file core/tests/Drupal/FunctionalJavascriptTests/Ajax/ElementValidationTest.php

Just a minor problem I can see -- which I want to fold into the next meaningful change.

public static $modules = ['ajax_test', 'ajax_forms_test'];

should be protected.

Fails for me locally too. We need to do some extra things to get the ajax to trigger here.

This form though does some interesting thing when you do trigger ajax. The focus starts bouncing between the two field and this goes into an ajax request loop, so you need to take some steps to break out of that again.

This is more about getting this green than about getting this right. If we can prevent the ajax ping-pong this would probably be cleaner.

Thanks for solving the problem,

Having that understanding it really useful...

PS

I am currently starting a online petition to get the "Gordian Knot" renamed the "Lendude Knot".

@martin107 I'm always up for a nice puzzle :)

Little clean up. The ping-pong happens because after the ajax call the focus returns to the text field that triggered it, so if you go to another field with a blur event that returns the focus to itself when its own ajax call finishes.....ping pong!

So the only safe way to clear focus is to reload the page. This seems like a bug to me, but that seems out of scope for this conversion.

proper javascript testing++

I think this version is as clean as we can get it.

Overall patch looks good to me. Just found some nits.

+++ b/core/tests/Drupal/FunctionalJavascriptTests/Ajax/ElementValidationTest.php
@@ -0,0 +1,51 @@
+    $this->getSession()->getPage()->fillField('drivertext', 'some dumb text');
...
+    $this->getSession()->getPage()->findField('spare_required_field')->focus();
...
+    $this->getSession()->getPage()->fillField('drivernumber', '12345');
+    $this->getSession()->getPage()->findField('spare_required_field')->focus();

At least we can have $session local var. :)

+++ b/core/tests/Drupal/FunctionalJavascriptTests/Ajax/ElementValidationTest.php
@@ -0,0 +1,51 @@
+    $placeholder_text = $this->assertSession()->waitForElement('css', "ul.messages__list li.messages__item em:contains('some dumb text')");
...
+    $placeholder_number = $this->assertSession()->waitForElement('css', "ul.messages__list li.messages__item em:contains('12345')");

$assert_session please.

@jibran thanks as always for the review.

Feedback addressed.

Thanks, for addressing the feedback.

Committed ebee0dc and pushed to 8.7.x. Thanks!

Cherry picked as f2e993d2c8 and pushed to 8.6.x