Convert AJAX part of \Drupal\responsive_image\Tests\ResponsiveImageFieldUiTest to JavascriptTestBase and the rest to BrowserTestBase

Updated the title and IS to reflect the increased scope for the issue, the BrowserTestBase conversion is now part of this issue.

I will try to prepare patch today on Drupal Global CodeSprint Jan 2018

seems form has hidden fields (e.g refresh_rows), that's why we need to wait when #2917885: Add drupalPostFormWithInvalidOptions() to BrowserTestBase lands.

Set proper status.
Postponed on #2917885: Add drupalPostFormWithInvalidOptions() to BrowserTestBase

Can we find a way to work around the hidden fields?

Still working on this issue, converted a first part of the old test, still have to convert the last part, but uploading my current progress already.

@brentgees really nice work on this! Since this is one of the last remaining conversions, I'm giving this a little push.

Thanks for the push, glad to see most of my code was already decent.

In my opinion your test looks good, but I would prefer someone else having a look as well before putting this to reviewed since my knowledge is a bit limited on WebDriverTestBase.

Thanks, patch looks great RTBC.

Committed and pushed 56658f00e7 to 8.7.x and 6531ee4b1c to 8.6.x. Thanks!

I tested locally on 8.6.x and everything passed.

+++ b/core/modules/responsive_image/src/FunctionalJavascript/ResponsiveImageFieldUiTest.php
@@ -0,0 +1,164 @@
+use Drupal\Tests\field_ui\Traits\FieldUiTestTrait;
...
+
+
+  use FieldUiTestTrait;

I don't think we need this trait at all.

I ran the tests locally without it and everything was fine.

diff --git a/core/modules/responsive_image/src/FunctionalJavascript/ResponsiveImageFieldUiTest.php b/core/modules/responsive_image/src/FunctionalJavascript/ResponsiveImageFieldUiTest.php
index a726b75b95..e7e3f753a0 100644
--- a/core/modules/responsive_image/src/FunctionalJavascript/ResponsiveImageFieldUiTest.php
+++ b/core/modules/responsive_image/src/FunctionalJavascript/ResponsiveImageFieldUiTest.php
@@ -4,7 +4,6 @@
 
 use Drupal\FunctionalJavascriptTests\WebDriverTestBase;
 use Drupal\responsive_image\Entity\ResponsiveImageStyle;
-use Drupal\Tests\field_ui\Traits\FieldUiTestTrait;
 
 /**
  * Class ResponsiveImageFieldUiTest.
@@ -13,9 +12,6 @@
  */
 class ResponsiveImageFieldUiTest extends WebDriverTestBase {
 
-
-  use FieldUiTestTrait;
-
   /**
    * Modules to install.
    *

Did this on commit.