Browser tests fail under HTTPS

I have applied the patch but is unsure about how to test it.Can you please check it and suggest any changes needed?

You need to replace the call to \Drupal::httpClient() with your new code. Well I guess you need to setup https on your local system in order to test it?

Adding patch.

Thank you

@chx
It would be great if you could confirm that this fixes your issue.

Ugh, ugly.

Can we have a comment why we need to do this? Like "Disable SSL peer verification so that testing under HTTPS always works."

Maybe a pointer to #268148: Browser tests fail under HTTPS would be great as well.

Replaced Code and added suggested Comment

Hm, looks like that is not a valid patch file? Can you create it with "git diff" as outlined on https://www.drupal.org/node/707484 ?

Created valid patch based on current 8.2.x-dev.

1. +++ b/core/tests/Drupal/Tests/BrowserTestBase.php
   @@ -357,8 +357,9 @@ protected function initMink() {
   +      // Also, disable SSL peer verification so that testing under HTTPS always works.
   

   Comment is over 80 characters, make sure to wrap the line at 80.

2. +++ b/core/tests/Drupal/Tests/BrowserTestBase.php
   @@ -357,8 +357,9 @@ protected function initMink() {
   -      $client = $this->container->get('http_client_factory')->fromOptions(['timeout' => NULL]);
   +      $client = $this->container->get('http_client_factory')->fromOptions(['timeout' => NULL, 'verify' => FALSE]);
   

   this line is getting long as well, let's do the array entries on separate lines.

As requested comment is wrapped at a line length of 80 chars and the array entries are on separate lines.

Manual test fails without this patch with a self-signed certificate and passes with. Happy to RTBC as soon as @klausi is happy with his feedbacks at #15.

IMHO for the sake of testing Drupal, it doesn't matter what protocol you use.
But if you HAVE TO run tests against a https environment (i.e.: due client requirements), it means the https is a requirement for you test and so it NEEDS to be a verified SSL cert.
Testing on https without verifying is more or less like testing through http.

Sorry, left-over. Reverting to Needs Review.

Thanks!

+++ b/core/tests/Drupal/Tests/BrowserTestBase.php
@@ -357,8 +357,13 @@ protected function initMink() {
+      $client = $this->container->get('http_client_factory')->fromOptions([
+        'timeout' => NULL,
+        'verify' => FALSE
+      ]);

there is a comma missing on the 'verify' line.

Added the missing comma.

Looks good, thanks!

Unfortunately needs a re-roll.

+++ b/core/tests/Drupal/Tests/BrowserTestBase.php
@@ -357,8 +357,13 @@ protected function initMink() {
       // test running, but it is a problem when debugging.
+      // Also, disable SSL peer verification so that testing under HTTPS always
+      // works.

The Also,... can be merged with the comment on the previous line.

Re-roll and merge comments.

Back to RTBC then.

Committed/pushed to 8.4.x and cherry-picked to 8.3.x, thanks!