As Drupal 7 requires PHP 5.2.0+, a workaround for pre-5.1.0 PHP in node.module is obsolete. Namely, strtotime now returns FALSE on failure, instead of -1.

This patch removes the workaround.

CommentFileSizeAuthor
#1 node-php-quirk-279382-1.patch870 bytescburschka

Comments

cburschka’s picture

cburschka
they
commented
Status: Active » Needs review
StatusFileSize
new node-php-quirk-279382-1.patch870 bytes

Here.

Susurrus’s picture

Susurrus commented

Also see #279516: Remove workarounds for PHP versions less than 5.2.x for a general PHP4 workaround issue.

cburschka’s picture

cburschka
they
commented
Status: Needs review » Closed (duplicate)

Thanks. I'll check whether the fix is in there, and add it if not.

cburschka’s picture

cburschka
they
commented

Oh, I never checked how new that other issue was ;)

Susurrus’s picture

Susurrus commented

I've attached a patch to that new issue that includes your patch here. If you'd like to take over that issue or help with it, please feel free. I figured it was easier to have a single PHP4 workaround issue than a ton of little ones.