Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
The Outside In prototype introduced in #2753941: [Experimental] Create Outside In module MVP to provide block configuration in Off-Canvas tray and expand site edit mode does not currently work in Safari on iOS.
In HEAD, contextual links are not responsive, and the pencil toggle to expose them is touchy and takes a few tries to trigger, but it does eventually open the contextual links.
With Outside In enabled, the pencil never works on my iPhone.
@drpal tested with an emulator and got a different (but also broken) result:
@drpal said:
Under some circumstance the function that toggles all the edit mode stuff to active is getting called twice.
which is turning it on, and then off again very quickly.
Note that it does work fine for me in a narrow window on Chrome, just not at all on my actual iPhone.
Proposed resolution
TBD
Remaining tasks
TBD
User interface changes
TBD
API changes
TBD
Data model changes
TBD
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | android-remote.gif | 699.24 KB | GrandmaGlassesRopeMan |
| #18 | IMG_3662.PNG | 101.37 KB | xjm |
| #15 | 2782899-15.patch | 2.28 KB | GrandmaGlassesRopeMan |
| #14 | android-remote.gif | 488.96 KB | GrandmaGlassesRopeMan |
| #13 | interdiff.txt | 1.93 KB | GrandmaGlassesRopeMan |
Comments
Comment #2
xjmComment #3
nod_Comment #4
webchickComment #5
tedbowComment #6
GrandmaGlassesRopeManThis fixes the issue with no
touchevents being recorded for toggling edit mode.Comment #7
webchickMarking for review.
Comment #8
GrandmaGlassesRopeManComment #9
wim leersWhy does
clicknot work at all for Outside In? Touch events are converted to click events, so I'm confused. Is Outside In perhaps doing something special with touch events elsewhere?Comment #10
GrandmaGlassesRopeMan@Wim Leers
That was my expectation also. However after mashing my finger against the edit button with nothing happened, adding a listener for
touchstartactually got this to work.Comment #11
GrandmaGlassesRopeManRerolled this patch based on #2786459: "Offcanvas" tray should be using the existing dialog system
Comment #12
GrandmaGlassesRopeManDuplicate commentComment #13
GrandmaGlassesRopeManThis fixes another issue where the local storage variable was not set on mobile, preventing the off canvas element from opening.
Comment #14
GrandmaGlassesRopeManComment #15
GrandmaGlassesRopeManRerolled this because #2787135: Editing mode gets "stuck" after switching between configuration of different blocks was merged.
Comment #16
tedbow@drpal nice work!
I have checked the patch on an iOs device and fixes the problem of it being broken.
I think there are other issue with the mobile experience but this address the specific concern here.
I filed #2793849: Handle offcanvas differently at lower widths as follow up for a problem I found. That issue doesn't break the functionality so shouldn't hold this up.
Comment #17
xjmComment #18
xjmSo following #2551785: Unable to scroll toolbar menu items or show contextual links on mobile browsers which was committed just this evening, HEAD is working much better on iOS. It is a little wonky and does have a layout bug for the main content area:
That's with HEAD. With this patch, it actually now seems broken again-but-differently... is there any chance this issue is a duplicate, or that our fix here is incompatible with the one there?
Comment #19
xjm(NW since the current patch actually seems to make things worse than HEAD, though this might just be a duplicate.)
Comment #20
GrandmaGlassesRopeManI just retested this from the current
HEAD. It appears that these fixes are no longer needed.Comment #21
wim leersEven better. The patch made no sense to me. Sounds like a race condition almost.
Comment #22
gábor hojtsyComment #23
tedbowChanging to new settings_tray.module component. @drpal thanks for script help! :)