Problem/Motivation

A default value of TRUE on a boolean filter results in no filter being applied. This is because \Drupal\views\Plugin\views\filter\FilterPluginBase::acceptExposedInput received $input = TRUE and then performs:

          if ($value == 'All' || $value === array()) {
            return FALSE;
          }

The non-strict comparison results in it incorrectly thinking it's in 'all' mode.

Proposed resolution

Switch to a strict comparison.

CommentFileSizeAuthor
#11 2734197-11-8.3.x.patch615 bytesyanniboi
#11 2734197-11.patch615 bytesyanniboi
#8 2734197-8.patch625 bytesyanniboi
#2 2734197-2.patch634 bytesandrewbelcher

Comments

andrewbelcher created an issue. See original summary.

andrewbelcher’s picture

andrewbelcher commented
StatusFileSize
new 2734197-2.patch634 bytes

Here's a patch that fixes the issue. I don't have time for tests now, but if no one else gets to it I will try and do that.

andrewbelcher’s picture

andrewbelcher commented
Status: Active » Needs review
lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Closed (duplicate)

This is a symptom of #2459289: Boolean default values are not saved, when that is fixed, this should work too.

andrewbelcher’s picture

andrewbelcher commented
Status: Closed (duplicate) » Postponed

I'm not 100% sure it is - while trying to fix I manually updated the yml and imported and was still having issues, which this resolved.

I suggest we postpone it until that one is resolved at which point we can confirm one way or the other.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Postponed » Postponed (maintainer needs more info)
Issue tags: +Needs tests

@andrewbelcher my bad, you are right, from what you describe this is unrelated. Was getting caught up in too many config related changes.

But I tried to reproduce this with an exposed non-grouped published filter on the content View and that was working fine with a default of 'Yes'.

Do you have steps to reproduce?

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

yanniboi’s picture

yanniboi commented
StatusFileSize
new 2734197-8.patch625 bytes

reroll

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

yanniboi’s picture

yanniboi commented
StatusFileSize
new 2734197-11.patch615 bytes
new 2734197-11-8.3.x.patch615 bytes

reroll

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Postponed (maintainer needs more info) » Closed (outdated)
Issue tags: -Needs tests +Bug Smash Initiative

@andrewbelcher, Thank you for reporting this problem. We rely on issue reports like this one to resolve bugs and improve Drupal core.

There has been no activity here for 5 years.

More information about this issue was asked for in #6, 6 years. No additional information has been supplied, therefor closing.

If you are experiencing this problem on a supported version of Drupal reopen the issue, by setting the status to 'Active', and provide complete steps to reproduce the issue (starting from "Install Drupal core").

Thanks!