Boolean exposed filter default values do not work correctly with AJAX enabled views

This looks perfect!

+++ b/core/modules/views/src/Plugin/views/filter/BooleanOperator.php
@@ -157,17 +157,25 @@ protected function valueForm(&$form, FormStateInterface $form_state) {
+    $value = $this->value;
...
+    if ($value !== 'All') {
+      $value = (int) $value;
+    }

How about $value = $this->value !== 'All' ? (int) $vlaue : 'All'; this for simplicity?

Hi Agreed with you, Assigning to me.

Used ternary Operations and uploaded new patch.

Seems pretty related to #1381140: A #default_value = 0 for #type radios checks all radios

@damiankloip Seems like #2732111: Reset button doesn't work and never gets removed on AJAX enabled views fixed it indeed, I can't reproduce this anymore using the steps in the IS. So do you think we should still make these changes more as hardening then an actual bug fix?
So change this from bug to task?
Or just leave it as is and close this?

re-rolled against 8.4.x and fixed the failure in #11.

The error seems to exist in multiple layers. To get my setup to work I had to fix #2712131: D8: Views: UI: -Any- option for non-required boolean yes/no filter won't stick as well.

And from point of view we have a real bug here, not a task. And it's not just limited to Ajax.

The patch from #20 applies cleanly to 8.4.x and creating a view as per the OP's description keeps the proper exposed filter settings.

This should be RTBC.

This should still be updated per #21 / #16.

Also:

+++ b/core/modules/views/src/Plugin/views/filter/BooleanOperator.php
@@ -162,17 +162,20 @@ protected function valueForm(&$form, FormStateInterface $form_state) {
+    // We can cast to an int here as if 'All' is used, it will be set from
+    // the user input.

This comment doesn't really make sense to me. It seems we are casting to int unless the value is 'All', but the comment makes it seem like it's the other way around.

I prefer the ternary operator. But I don't won't to block the solution here.

CI caused the fail. Retest succeeded.

I think this could use a test. I also don't 100% grok this issue yet, so I will use writing a test as an opportunity to fix that.

Hmm... so I followed the steps to reproduce in the issue summary but I couldn't reproduce the issue. The attached patch is a test that follows the steps to reproduce, as well. And it passes, instead of failing. Note that the title mentions "AJAX-enabled", but I couldn't reproduce this behavior with or without AJAX, so the patch currently leaves that out.

Marking "needs review", but this is really "needs work" until we get a failing "tests-only" patch.

@tstoeckler I think the actual issue was solved by #2732111: Reset button doesn't work and never gets removed on AJAX enabled views and the issue @mkalkbrenner ran into is solved by #1381140: A #default_value = 0 for #type radios checks all radios so I think this can be reset to a Task again, just for internal hardening of the used values, see #17/#18

Hmm... OK. Tagging "Needs issue summary update" then. It would be great to clarify what is being "hardened" here.

+++ b/core/modules/views/src/Plugin/views/filter/FilterPluginBase.php
@@ -1190,7 +1190,9 @@ protected function exposedTranslate(&$form, $type) {
-      $form['#default_value'] = 'All';
+      if (!isset($this->value)) {
+        $form['#default_value'] = 'All';

it needs code comment - why default value should "All" when no value?

@Lendude it's not solved yet, see #2745723: Exposed filter using checkbox always checked (e.g. history is-new)

I tested this on Drupal 10.1.x, umami install. I added a boolean to a new content type and followed the steps in the Issue Summary. I was not able to reproduce the problem. After filtering on 'any', 'true' or 'false' and then clicking 'reset' the filter was set to the default value of True.

Therefor, I am closing this as outdated.

Thanks.