D8: Views: UI: -Any- option for non-required boolean yes/no filter won't stick [#2712131]

Field type: Boolean

When set non-required filter on the Boolean field the -Any- choice does not stick.

On loading/running the saved view (without any query params) it always shows True or Fallse; -Any-is available, but not selected by default as desired.

Next time open up the Views UI config for that filter it always shows one of True or False, never -Any- as previously.

Snippet from views Single item YAML export:

        field_d8_wishlist_value:
          id: field_d8_wishlist_value
          table: node__field_d8_wishlist
          field: field_d8_wishlist_value
          relationship: none
          group_type: group
          admin_label: ''
          operator: '='
          value: true
          group: 1
          exposed: true
          expose:
            operator_id: ''
            label: 'On Webel''s D8 Wishlist'
            description: ''
            use_operator: false
            operator: field_d8_wishlist_value_op
            identifier: field_d8_wishlist_value
            required: false
            remember: true
            multiple: false
            remember_roles:
              anonymous: anonymous
              authenticated: authenticated
              administrator: '0'
              author: '0'
              developer: '0'
          is_grouped: false

Note value: true although -Any was chosen and applied then view saved.

Comment	File	Size	Author
#4	2712131.patch	980 bytes	mkalkbrenner

Comments

Comment #1

23 April 2016 at 11:11

webel created an issue. See original summary.

Comment #2

dawehner

German

commented 25 April 2016 at 06:31

Component:

views_ui.module

» forms system

Thank you for reporting this issue! Small improvements matter!

After some hour of debugging that problem I figured out that \Drupal\Core\Render\Element\Radio::preRenderRadio seems to have a bug.
If you check out the HTML of the form correctly, you'll see that both the All and the False element is marked with checked="checked". This is caused by the following line
if (isset($element['#return_value']) && $element['#value'] !== FALSE && $element['#value'] == $element['#return_value']) { in this preRenderRadio method.

I think the right method would be to check whether the value is a boolean/integer, casts them to their type and then do a "===", but I'm not sure about the correct fix.