actions_syncronize() didn't use db_placeholders() as it should've plus a few other small changes.

CommentFileSizeAuthor
#3 266773.actions_syncronize.patch1.81 KBdave reid
actions.inc_.patch2.2 KBSusurrus

Comments

Susurrus’s picture

Susurrus commented

Also, I pegged #246522: Typo in function documentation in actions.inc into this patch as it's such a small change that I figured it'd get in easier if it was part of a more worthwhile patch.

Susurrus’s picture

Susurrus commented

All SimpleTests still pass, though I'm not sure if any test this function.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 266773.actions_syncronize.patch1.81 KB

Nice job. Re-rolled patch for changes to actions.inc and works perfectly.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Reviewed & tested by the community

Patch still applies cleanly, passes all tests, and provides a small cleanup in code that reduces 11 lines of code to 3 without increasing complexity. Ready to be committed.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

I've asked John to take a look at this.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs review
jvandyk’s picture

jvandyk commented
Status: Needs review » Reviewed & tested by the community

Tested and works as expected.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed. :)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.