Comments

twistor created an issue. See original summary.

twistor’s picture

Test to illustrate the problem.

twistor’s picture

Status: Active » Needs review
twistor’s picture

The last submitted patch, 2: 2660754-1-should-fail.patch, failed testing.

twistor’s picture

Those 5.4 failures don't make any sense.

twistor’s picture

I wonder how many failures there will be this time.

twistor’s picture

David_Rothstein’s picture

Status: Needs review » Reviewed & tested by the community

I tried to figure out if historically there was some reason they expected the actual output to be '09876...' rather than '9876...' but couldn't find one. So I guess it was just a bug in the test and it should have been checking for '9876...' all along.

Therefore, marking this RTBC - thanks!

Fabianx’s picture

RTBC + 1, Marking for commit.

  • Fabianx committed 4d5d300 on 7.x
    Issue #2660754 by twistor, David_Rothstein: Invalid numeric comparison...
Fabianx’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -Pending Drupal 7 commit

Committed and pushed to 7.x! Thanks!

Giving credit to David for his research.

Fabianx’s picture

Issue tags: +PHP 5.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.