Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch created an issue. See original summary.

catch’s picture

David_Rothstein’s picture

Priority: Critical » Major
Status: Active » Needs review
FileSize
427 bytes

The testbot results linked from the issue summary no longer exist for some reason, so here's a no-op patch that we can use to get direct test results in this issue.

Also I think this should be major rather than critical unless we identity something that's actually seriously broken on PHP 5.4 (but as far as I know there isn't; the test failures are likely to be more minor issues). It would definitely be nice to be able to reliably use the Drupal 7 testbot on PHP 5.4 though.

twistor’s picture

twistor’s picture

This should fix everything except UpgradePathTaxonomyTestCase.

defconjuan’s picture

Issue summary: View changes
twistor’s picture

Issue summary: View changes
twistor’s picture

twistor’s picture

I've managed to convince the testbot to pass all 4 issues above.

There were 4 failures in total. Each issue brings it down to 3 failures. Here's a test to prove all failures are fixed.

Status: Needs review » Needs work

The last submitted patch, 10: 2620104-php54-10.patch, failed testing.

twistor’s picture

Status: Needs work » Needs review
FileSize
13.11 KB

Last patch contained some other nonsense.

Status: Needs review » Needs work

The last submitted patch, 12: 2620104-php54-12.patch, failed testing.

twistor’s picture

Status: Needs review » Needs work

The last submitted patch, 14: 2620104-php54-12.patch, failed testing.

twistor’s picture

Status: Needs work » Needs review
twistor’s picture

5.3 and 5.4 are both passing with the related issues compiled into a single patch. I added 5.5 just for fun.

isntall’s picture

I just ran the patch from #12

  • 11 times with the web-5.4 and mysql-5.5 containers with a concurrency of 16 and they all passed.
  • 5 times with the web-5.5 and mysql-5.5 containers with a concurrency of 16 and they all had failures.

So this looks to be an issue with the concurrency causing tables to be deleted before they should.

On the old QA system we set the concurrency of Drupal 7 to 8, now we set the concurrency of 31. There were some issues with Drupal 8 and concurrency a while ago, though I don't remember the node IDs.

Fabianx’s picture

Issue tags: +7.50 release notes
Fabianx’s picture

Issue tags: +PHP 5.4
Fabianx’s picture

Status: Needs review » Fixed

Fixed PHP 5.4 passes now as far as I can see.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.