Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
https://www.drupal.org/pift-ci-job/153442
https://www.drupal.org/pift-ci-job/153442
Comments
Comment #2
catchComment #3
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedThe testbot results linked from the issue summary no longer exist for some reason, so here's a no-op patch that we can use to get direct test results in this issue.
Also I think this should be major rather than critical unless we identity something that's actually seriously broken on PHP 5.4 (but as far as I know there isn't; the test failures are likely to be more minor issues). It would definitely be nice to be able to reliably use the Drupal 7 testbot on PHP 5.4 though.
Comment #4
twistor CreditAttribution: twistor as a volunteer commentedComment #5
twistor CreditAttribution: twistor as a volunteer commentedThis should fix everything except UpgradePathTaxonomyTestCase.
Comment #6
twistor CreditAttribution: twistor as a volunteer commentedComment #7
defconjuan CreditAttribution: defconjuan commentedComment #8
twistor CreditAttribution: twistor as a volunteer commentedComment #9
twistor CreditAttribution: twistor as a volunteer commentedI've created 4 sub-issues for the related failures:
The testbot seems to be having random failures for unrelated things making this more difficult than necessary.
Comment #10
twistor CreditAttribution: twistor as a volunteer commentedI've managed to convince the testbot to pass all 4 issues above.
There were 4 failures in total. Each issue brings it down to 3 failures. Here's a test to prove all failures are fixed.
Comment #12
twistor CreditAttribution: twistor as a volunteer commentedLast patch contained some other nonsense.
Comment #14
twistor CreditAttribution: twistor as a volunteer commentedComment #16
twistor CreditAttribution: twistor as a volunteer commentedComment #17
twistor CreditAttribution: twistor as a volunteer commented5.3 and 5.4 are both passing with the related issues compiled into a single patch. I added 5.5 just for fun.
Comment #18
isntall CreditAttribution: isntall at Drupal Association commentedI just ran the patch from #12
So this looks to be an issue with the concurrency causing tables to be deleted before they should.
On the old QA system we set the concurrency of Drupal 7 to 8, now we set the concurrency of 31. There were some issues with Drupal 8 and concurrency a while ago, though I don't remember the node IDs.
Comment #19
Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commentedComment #20
Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commentedComment #21
Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commentedFixed PHP 5.4 passes now as far as I can see.