When sending a PATCH request to Drupal 8, I noticed that all the log messages coming from the Rest module were missing Entity IDs (ex: "Updated entity node with ID .").

The attached patch uses the $original_entity's ID, instead of trying to pull an ID from the passed in $entity (which only contains updatable fields/properties).

CommentFileSizeAuthor
fix-rest-module-patch-log.patch877 bytessamuel.mortenson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

samuel.mortenson created an issue. See original summary.

Boyquotes’s picture

Boyquotes CreditAttribution: Boyquotes as a volunteer and commented
Status: Needs review » Reviewed & tested by the community

We (Celdia https://www.drupal.org/u/celdia, vanilla-bear https://www.drupal.org/u/vanilla-bear and me https://www.drupal.org/u/boyquotes ) have reproduced this bug and we have tested this patch and it works

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

The fix looks good. I was pondering whether or not test coverage was worth it. I don't think so. Committed 236206a and pushed to 8.0.x. Thanks!

  • alexpott committed 236206a on 8.0.x 
    Issue #2554873 by samuel.mortenson: Log message in Drupal\rest\Plugin\...
celdia’s picture

celdia CreditAttribution: celdia commented

Thanks for your testing and confirmation. I also think it must be good.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.