Attached are assertions for the classes of the theme namespace that are believed to be good (the PHPUnit tests pass locally). Child tickets for this are the assertions that aren't currently passing for one reason or another.

Refer to the do not test diff as it contains only the code relevant to this issue. The tested patch has the parent ticket code with its tools.

CommentFileSizeAuthor
#12 core_theme_assertions-2516624-12.patch13.73 KBrumburak
#9 core_theme_assertions-2516624-9.patch13.73 KBrumburak
#7 core_theme_assertions-2516624-7.patch13.73 KBrumburak
theme-assertions--do-not-test.diff13.85 KBAki Tendo
theme-assertions.diff35.83 KBAki Tendo

Comments

Status: Needs review » Needs work

The last submitted patch, theme-assertions.diff, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

markdorison’s picture

markdorison
he/him
commented
Version: 8.1.x-dev » 8.3.x-dev

Patch no longer applies cleanly.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue tags: +Needs reroll
rumburak’s picture

rumburak commented

Hi, I am in DrupalCon Dublin and starting to work on this.

danylevskyi’s picture

danylevskyi
Location Myrhorod / Ukraine
commented

Helping to working on the issue.

rumburak’s picture

rumburak commented
Status: Needs work » Needs review
StatusFileSize
new core_theme_assertions-2516624-7.patch13.73 KB

Here is the fixed patch with refactoring based on the last version of 8.3.x.

Status: Needs review » Needs work

The last submitted patch, 7: core_theme_assertions-2516624-7.patch, failed testing.

rumburak’s picture

rumburak commented
Status: Needs work » Needs review
StatusFileSize
new core_theme_assertions-2516624-9.patch13.73 KB

Second fix for the patch, refactoring code for the assertion on the constructor for ThemeInitialization.php.

Status: Needs review » Needs work

The last submitted patch, 9: core_theme_assertions-2516624-9.patch, failed testing.

stefan.r’s picture

stefan.r commented
Issue tags: +Dublin2016

helping rumburak with this -- but we'll need to check what the status of assertions in D8 is, I don't know that we're using many of them yet, and there were some concerns around security?

rumburak’s picture

rumburak commented
Status: Needs work » Needs review
StatusFileSize
new core_theme_assertions-2516624-12.patch13.73 KB

Hope this is the good one... Refactored the use of the Assertion class into the Inspector one.

rumburak’s picture

rumburak commented
Status: Needs review » Needs work

It seems there still are some issues with the code for the assert:
assert('\\Drupal\\Component\\Assertion\\Inspector::assertAllObjects($this->sortedNegotiators, \'\\Drupal\\Core\\Theme\\ThemeNegotiatorInterface\')');
and
assert('\\Drupal\\Component\\Assertion\\Inspector::assertAllObjects($base_themes, \'\Drupal\\Core\\Extension\\Extension\')');

I will check better the proper syntax for this, I have to run now to catch the flight.

The last submitted patch, 12: core_theme_assertions-2516624-12.patch, failed testing.

manuel garcia’s picture

manuel garcia commented
Issue tags: -Needs reroll

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +stale-issue-cleanup

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Believe this can be closed as we are now typehinting and adding return types.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.