Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it corrects a typo in the documentation.
Issue priority Minor because this is a simple typo fix in the documentation.
Unfrozen changes Unfrozen because it only changes documentation.

Follow-up to #2508666: Drupal 8 .htaccess rule to prevent php file access can be easily bypassed

The above issue committed a typo to a comment in HtaccessTest::testFileAccess():

    // Test that is it possible to have path aliases containing .php.
    $type = $this->drupalCreateContentType();

should be:

    // Test that it is possible to have path aliases containing .php.
    $type = $this->drupalCreateContentType();
CommentFileSizeAuthor
#6 2511348-7.patch692 byteskfitz

Comments

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented

I could find any typo

cilefen’s picture

cilefen commented

@joshi.rohit100 Can we please leave this for a novice?

"Test that is it possible to have path aliases containing .php." is not a proper sentence in English. "is it" does not follow certain words such as "that". For example, you could ask someone "Is it raining today?", or you could ask "I wonder, is it raining today?", or you could say "I wonder if it is raining today."

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

I missed noticing that typo too! Would have been nice to point it out in the issue summary in the first place. :)

But as far as "leaving this for a novice", I wouldn't say that.... Putting a Novice tag on an issue doesn't mean that someone who has contributed before shouldn't take it on and make a patch. We should appreciate anyone who wants to contribute, and appreciate that the issue actually gets fixed, which I think is the main goal.

We have 35 issues that are "Active" status and tagged "Novice" right now in Drupal Core -- not even including ones that are in other statuses. I don't think there is a shortage of things for people to work on.

fabianx’s picture

fabianx commented
Issue summary: View changes

.

cilefen’s picture

cilefen commented

Of course you are right about not "holding" issues. I don't even want to get into the misuse of the Novice tag. This issue is actually "Novice".

kfitz’s picture

kfitz commented
StatusFileSize
new 2511348-7.patch692 bytes

Created patch to correct typo.

dylf’s picture

dylf commented
Status: Active » Reviewed & tested by the community

The most recent patch corrects the typo, solving this issue.

star-szr’s picture

star-szr
he/him
Primary language English
commented

+1 :)

Thanks all, especially @cilefen for creating the issue.

dylf’s picture

dylf commented
Issue summary: View changes
dylf’s picture

dylf commented
Issue summary: View changes
dylf’s picture

dylf commented
Priority: Normal » Minor
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 0ee13d3 and pushed to 8.0.x. Thanks!

  • alexpott committed 0ee13d3 on 8.0.x 
    Issue #2511348 by kfitz, dylanf, cilefen: HtaccessTest::testFileAccess...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.