Remove SafeMarkup::set in StylePluginBase::renderFields

No worries, these failures seem to be prove that this SafeMarkup::set() isn't really safe.
Either: $values and/or $rendered_field are not safe going in. May need to escape them before.

Wrong parent issue I think. :)

Looked up replace to better understand what @joelpittet said in #7

   * Replaces all occurrences of the search string with the replacement string.
   *
   * Functions identically to str_replace(), but marks the returned output as
   * safe if all the inputs and the subject have also been marked as safe.
   *

So, I'm going to just try some things. :)

So.

some fails were:

Drupal\action\Tests\ActionUninstallTest 13 0 12
Message Group Filename Line Function Status
Array to string conversion Notice SafeMarkup.php 94 Drupal\Component\Utility\SafeMarkup::isSafe()

so I guess we need to escape each string that could be in the arrays.

... but why are the placeholders and the values the same?

oh, they are not, one is the array values and the other is the array keys. :)

here is a try at escaping all of both.

--
xjm also suggested

this might be a ok to use SafeMarkup::set(), because in theory it's behind a Views admin permission
stepping through it in a debugger could be helpful though time-consuming

[edit: oops. that interdiff should have ended in .txt so it would not have been sent to the testbot. oops.]

as this is views specific, adding a tag for that.

This SafeMarkup::set() is removed as part of #2506581: Remove SafeMarkup::set() from Renderer::doRender - it is still mark the content here as safe but in a different way. I think everything here should be already safe because it has come from the render system already.

#18: so should we close this as a duplicate then? Or postpone it until the other lands and then re-evaluate?

Postpone for now, and close as duplicate if and when that lands. If not, re-open:)

Before closing, make sure this has been resolved please.

#2506581: Remove SafeMarkup::set() from Renderer::doRender

Unpostponing

SafeMarkup::set was removed from this class in #2506581: Remove SafeMarkup::set() from Renderer::doRender.