Problem/Motivation

From #2454439-25: [META] Support PHP 7, the parent method is new and the method in this class doesn't match the parent.

Proposed resolution

Rename the method.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 node-strict-standards-context-2465005-1.patch2.76 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new node-strict-standards-context-2465005-1.patch2.76 KB

And here's the relevant part of the patch extracted from over there.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix
fabianx’s picture

fabianx commented

RTBC + 1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 56bf922 and pushed to 8.0.x. Thanks!

  • alexpott committed 56bf922 on 8.0.x 
    Issue #2465005 by Berdir: PHP Strict Standards in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.