Comment field settings don't save

Agreed on the fix, a bit sad that there isn't a simpler way ?

+++ b/core/modules/comment/src/Plugin/Field/FieldType/CommentItem.php
@@ -210,4 +212,17 @@ public function storageSettingsForm(array &$form, FormStateInterface $form_state
 
+  /**
+   * Form builder process callback.
+   */
+  public static function processCommentSettings(&$element) {
+    $parents = $element['#parents'];
+    // Remove the 'comment' nesting.
+    array_pop($parents);
+    foreach (Element::children($element) as $key) {
+      $element[$key]['#parents'] = array_merge($parents, array($key));
+    }
+    return $element;
+  }
+

it sounds like a generic functionality for me. Can't we provide some kind of process callback in FAPI somewhere? Note: I have seen a similar thing in SystemMenuBlock

So the case is "I don't know which form structure I'm embedded into, but I want my values sub-array to be structured that way".

Our current tools (#tree, #parents) do not allow this, but ideally, such things could be expressed directly in the $element sub form without having to resort to process callbacks ?

Looks good to me

+++ b/core/modules/comment/src/Plugin/Field/FieldType/CommentItem.php
@@ -106,21 +107,13 @@ public function fieldSettingsForm(array $form, FormStateInterface $form_state) {
-      '#attached' => array(
-        'library' => array('comment/drupal.comment'),
-      ),

Is this not used?

I think I found one other place which looks up this variable using the wrong key:

http://cgit.drupalcode.org/drupal/tree/core/modules/comment/src/CommentA...

$anonymous_contact = $commented_entity->get($entity->getFieldName())->getFieldDefinition()->getSetting('anonymous_contact');

Thanks, good work!

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 125424b and pushed to 8.0.x. Thanks!