Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views_ui.module
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Oct 2014 at 11:36 UTC
Updated:
12 Nov 2014 at 09:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerGood observation!
Do you want to try to fix it?
core/modules/views_ui/src/ViewDuplicateForm.phpwould be the URL you need.Comment #2
zaporylieI will provide a patch
Comment #3
zaporylieLets try
Comment #4
lhangea commentedTested the patch. It fixes the problem.
Comment #5
alexpottSo we must be missing test coverage of this.
Comment #6
zaporylieThat's what I thought :) I will provide one later today or tomorrow.
Comment #7
zaporylieComment #8
zaporylieOk, here's the patch. This is my very first Test class so, please, review it carefully.
Comment #9
zaporylieComment #10
dawehnerIt would be great if we could name things here as duplicate, given that also the UI is talking about duplicating.
+1
Comment #11
zaporylieThanks for review. I've changed name convention from clone to duplicate.
Comment #12
jsobiecki commented+1 from me. Patch applies cleanly, all tests are green and what most important - it fixes reported bug :).
From technical side - change is quite simple - nothing suspicious here. Patch includes also new test case for test suite.
Comment #13
dawehnerCool, thank you!
Comment #14
alexpottCommitted 5a3027c and pushed to 8.0.x. Thanks!