Default contact form does not send email as email recipient is not set during the installation.

1. +++ b/core/modules/contact/src/MailHandler.php
   @@ -103,6 +103,12 @@ public function sendMailMessages(MessageInterface $message, AccountInterface $se
   +        // If email is not set from the contact form configuration (only possible
   +        // in the default site form that comes with the installation), send to the site's email.
   

   The comment line should end at 80 characters or less. If a word exceeds this, then you should start a new line.

2. +++ b/core/modules/contact/src/MailHandler.php
   @@ -103,6 +103,12 @@ public function sendMailMessages(MessageInterface $message, AccountInterface $se
   +        $to = \Drupal::config('system.site')->get('mail');
   

   Would it be possible to inject the configuration class into MailHandler?

   This would be an API change, but would be better code.

We probably need a test for this as our current tests haven't caught the issue. A test would assert that the recepient of the mail is system.site.mail via assertMail... methods.

To inject the service you would need to modify contact.services.yml and add @config.factory service (iirc on the service name in core.services.yml).

Then __construct needs to be modified to set $this->config = ConfigFactory.... there are some examples around core.

Does the default form live in standard profile? If so the fix should be to load the form config entity in standard_install() and set using the value in config

The patch attached from yannisc works properly!

--- a/core/lib/Drupal/Core/Installer/Form/SiteConfigureForm.php
+++ b/core/lib/Drupal/Core/Installer/Form/SiteConfigureForm.php

@@ -274,6 +274,13 @@ public function submitForm(array &$form, FormStateInterface $form_state) {
+    if (\Drupal::moduleHandler()->moduleExists('contact')) {

We should use $this->moduleHandler, which is already injected. Otherwise, I think is RTBC.

Oh! And we need tests too!

Installer tests are in Drupal\system\Tests\Installer. You should extend InstallerTestBase. Look at Drupal\system\Tests\Installer\SiteNameTest as an example.

This is wrong. You said earlier that contact.form.feedback lives in standard profile. In which case globally changing the installer for all profiles is wrong. Please add a hook form alter to standard profile that adds a new submit handler which in turn updates the config.

But what about a contrib profile that includes contact module but not the feedback form?

No, as said in #5 this is an issue with standard profile, nothing to do with contact.

Here's how I think it should be done, as well as a test to verify it works.
Test only patch is the .fail one - should come back red.
Pass patch should come back green.

#21 is RTBC, test coverage++.

Nice find, nice fix and nice test.

Committed 62f8b46 and pushed to 8.0.x. Thanks!

hmmm... actually contact.form.feedback is provided by the contact module. Reverted the change for now.

I think we should consider moving the feedback form to the standard profile.

Lets move it to standard

Feedback form is in standard profile instead of the contact module as alexpott suggested.

--- /dev/null
+++ b/core/modules/contact/tests/modules/contact_test/contact_test.info.yml

Missing hidden: true?

Otherwise, RTBC.

Talked with larowlan on IRC.
After checking #2188661: Extension System, Part II: ExtensionDiscovery (item 1.4 on proposed resolution) and looking at the existing test modules, if we grep'ed correctly there are only 3 which define hidden:true. So not a requirement then.

Nice - only if all core modules did the same as contact - yep I'm looking at you forum, book, node and views. Moving all "feature-like" config entities into standard will be awesome - roll on 9.x :)

Committed 9a19c4e and pushed to 8.0.x. Thanks!

contact_install() still has this:

  $config = \Drupal::config('contact.form.feedback');
  // Update the recipients if the default configuration entity has been created.
  // We should never rely on default config entities as during enabling a module
  // during config sync they will not exist.
  if (!$config->isNew()) {
    \Drupal::config('contact.form.feedback')->set('recipients', array($site_mail))->save();
  }

That's dead code now?

Opened #2362519: Remove dead code from contact.install