Problem/Motivation

There are a couple places in Views where a form_state key is called 'js settings'

Proposed resolution

Switch that to 'js_settings'

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#6 Drupal-js_settings-2336481-6.patch845 bytespushpinderchauhan
#2 Drupal-js_settings-2336481-2.patch879 bytesthomwilhelm

Comments

thomwilhelm’s picture

thomwilhelm commented

I'll have a look at this, it should be an easy patch to create.

thomwilhelm’s picture

thomwilhelm commented
Status: Active » Needs review
StatusFileSize
new Drupal-js_settings-2336481-2.patch879 bytes
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Postponed

My mistake, I meant to postpone this on #2335659: Remove FormState ArrayAccess usage from core, sorry @ThomWilhelm!
Once that is in I will reopen this, since those lines are moving, and it can be rerolled.

thomwilhelm’s picture

thomwilhelm commented

After submitting this I was googling about form state in Drupal 8 and found some information about it being a class now, so I did wonder why this was still referring to an array :) https://www.drupal.org/node/2310411

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Postponed » Needs work

This is good to go!

pushpinderchauhan’s picture

pushpinderchauhan commented
Status: Needs work » Needs review
StatusFileSize
new Drupal-js_settings-2336481-6.patch845 bytes

Please review attached patch.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

Thanks to both @ThomWilhelm and @er.pushpinderrana!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 698360a and pushed to 8.0.x. Thanks!

  • alexpott committed 698360a on 8.0.x 
    Issue #2336481 by er.pushpinderrana, ThomWilhelm | tim.plunkett: Replace...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.