Create migrations for status/promote/sticky

Let the bot pick up the patches...

and back to postponed.

That looks good.

Back to RTBC if green. The schema change looks OK.

Back to RTBC.

+++ b/core/modules/migrate_drupal/src/Tests/d6/MigrateNodeTypeTest.php
@@ -52,16 +47,6 @@ public function testNodeType() {
-        'revision' => FALSE,

@@ -71,15 +56,6 @@ public function testNodeType() {
-        'revision' => FALSE,

@@ -89,16 +65,6 @@ public function testNodeType() {
-        'revision' => TRUE,

We should still be testing the revision value.

OK let's try this again.

+++ b/core/modules/migrate_drupal/src/Tests/d6/MigrateNodeTypeTest.php
@@ -91,14 +83,12 @@ public function testNodeType() {
-        'revision' => TRUE,
+        'revision' => FALSE,

This change surprises me - since we've not changed the test data. Also I think this means we are not testing that we've migrated a revision set to TRUE successfully either.

+++ b/core/modules/migrate_drupal/config/install/migrate.migration.d6_node_type.yml
@@ -16,7 +16,7 @@ process:
-  'settings/node/options': options
+  'settings/node/options/revision': 'options/revision'
   create_body: has_body

chx ensured that this is the only option beside the other ones.

What do I know. For me Drupal 6 is history I am slowly forgetting the nuances of. But look https://api.drupal.org/api/drupal/modules!node!content_types.inc/functio...

    '#options' => array(
      'status' => t('Published'),
      'promote' => t('Promoted to front page'),
      'sticky' => t('Sticky at top of lists'),
      'revision' => t('Create new revision'),
    ),

so... yeah.

+++ b/core/modules/migrate_drupal/src/Tests/d6/MigrateNodeTypeTest.php
@@ -78,8 +71,7 @@ public function testNodeType() {
-    // $this->assertEqual($node_type_story->settings['node'], $expected, 'Node type test_story settings correct.');
+    $this->assertEqual($node_type_page->settings['node'], $expected);

Same problem

Just a note: I'm changing those commented out assertions that are enabled again here in #2324121: NodeType's settings array was meant to be able to store information from mutliple modules. Will conflict in case that will get committed first.

#23 was RTBC, one complaint raised, addressed since. Should be ready.

Committed d7840d6 and pushed to 8.0.x. Thanks!