Remove drupal_redirect_form() as it is deprecated as per meta https://www.drupal.org/node/2205673

usage is removed here https://www.drupal.org/node/2300873

submitted patch for the same.

CommentFileSizeAuthor
#7 remove-2300875-7.patch833 bytespenyaskito
#4 interdiff-2300875-3-4.txt436 bytesamitgoyal
#4 remove-drupal-redirect-form-2300875-4.patch1.38 KBamitgoyal
#3 remove-drupal-redirect-form-3.patch1.38 KBjoshi.rohit100
remove-drupal-redirect-form.patch797 bytesjoshi.rohit100

Comments

Status: Needs review » Needs work

The last submitted patch, remove-drupal-redirect-form.patch, failed testing.

ParisLiakos’s picture

ParisLiakos commented
Issue tags: -@depreacted +@deprecated

seems there are still usages

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs work » Needs review
StatusFileSize
new remove-drupal-redirect-form-3.patch1.38 KB

updated patch

amitgoyal’s picture

amitgoyal commented
StatusFileSize
new remove-drupal-redirect-form-2300875-4.patch1.38 KB
new interdiff-2300875-3-4.txt436 bytes

Minor fix for whitespace/tab error.

a_thakur queued 4: remove-drupal-redirect-form-2300875-4.patch for re-testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

The usage was already removed in #2300873: Remove usage of drupal_redirect_form() as deprecated, this needs to remove only the function.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
StatusFileSize
new remove-2300875-7.patch833 bytes
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Added this issue to the change record.

LinL’s picture

LinL commented
Status: Needs review » Reviewed & tested by the community

Change record looks good and this is the only occurrence of drupal_redirect_form() remaining so RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 7e23170 and pushed to 8.0.x. Thanks!

  • alexpott committed 7e23170 on 8.0.x 
    Issue #2300875 by joshi.rohit100, amitgoyal, penyaskito: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.