Remove the usage of drupal_redirect_form() as it is deprecated as per https://www.drupal.org/node/2205673.

once usages are removed, method is removed here https://www.drupal.org/node/2300875

Submitted patch for same.

CommentFileSizeAuthor
#3 interdiff-2300873-0-3.txt518 bytesamitgoyal
#3 remove-usage-drupal-redirect-form-2300873-3.patch615 bytesamitgoyal
remove-usage-drupal-redirect-form.patch607 bytesjoshi.rohit100

Comments

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Issue summary: View changes
Related issues: +#2300875: Remove drupal_redirect_form() as it is deprecated
ParisLiakos’s picture

ParisLiakos commented
Issue tags: -@depreacted +@deprecated 
+++ b/core/includes/batch.inc
@@ -445,8 +445,8 @@ function _batch_finished() {
+    // Use \Drupal\Core\Form\FormSubmitterInterface::redirectForm() to handle the redirection logic.

super nitpicky, sorry, this should be 80 chars max

amitgoyal’s picture

amitgoyal commented
StatusFileSize
new remove-usage-drupal-redirect-form-2300873-3.patch615 bytes
new interdiff-2300873-0-3.txt518 bytes

Please review revised patch with fixes in #2.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

great, thanks

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Can we add this issue to the relevant change record.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs work » Needs review

Added to relevent change notice https://www.drupal.org/node/2121003

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 2458d9e and pushed to 8.x. Thanks!

  • alexpott committed 2458d9e on 8.x 
    Issue #2300873 by amitgoyal, joshi.rohit100: Remove usage of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.