Closed (duplicate)
Project:
Drupal core
Version:
8.0.x-dev
Component:
Bartik theme
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
2 Jul 2014 at 19:59 UTC
Updated:
30 Dec 2014 at 11:17 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tkoleary commentedComment #2
Saphyel commentedThis is my first contributed patch for drupal core and I did in "Sprint day Zaragoza"
Comment #3
alexpottHi @Saphyel thanks for your first patch! Nice work. After a patch is submitted the status should be changed to "needs review". The review process is documented here https://www.drupal.org/contributor-tasks/review. An easy rule to remember is that you don't rtbc your own patches. You could help the reviewer by providing before and after screenshot.
Need a new line at the end of the file
Comment #4
emma.mariaComment #5
adci_contributor commentedIs it still actual to the current Bartik? When I tried to reproduce, text-color in a search form on the header region was #3b3b3b

(see input.form-search in /batrik/css/components/form.css).
However, attaching a reroll.
Comment #6
adci_contributor commentedComment #7
emma.mariaIf you cannot reproduce an issue, you can always set it to be Closed (cannot reproduce). If you are wrong someone will reopen it :)
Comment #8
emma.mariaI found the issue that duplicates this and was fixed #2281451: Search form enabled in header region does not show the typed text.. Closing this issue.