#2114823: Update PHPUnit to 4.x aims to upgrade PHPUnit for core from 3.7 to 4.1. In order to do that, the tests that use staticExpects() will have to be refactored, as that method was removed in PHPUnit 4.0.

CommentFileSizeAuthor
#1 drupal_2278705_1.patch10.19 KBxano

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Active » Needs review
StatusFileSize
new drupal_2278705_1.patch10.19 KB

These changes come straight from #2114823-29: Update PHPUnit to 4.x.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

cosmicdreams’s picture

cosmicdreams commented

+1 please commit.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit 5dc22c7 on 8.x by catch: 
    Issue #2278705 by Xano: Make all tests compatible with PHPUnit 4.
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Awesome! Let's get #2114823: Update PHPUnit to 4.x fixed now :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.