Comments

Status: Needs review » Needs work

The last submitted patch, testperf.search-SearchCommentTest.patch, failed testing.

jhodgdon’s picture

This test would need more changes than that to work. It is currently relying on the existence of the "Full HTML" text format and the "page" content type. That would need to be replicated. See in setUp():

   $permissions = array(
      'administer filters',
      $full_html_format->getPermissionName(),
      'administer permissions',
      'create page content',
      'skip comment approval',
      'access comments',
    );
sun’s picture

Status: Needs work » Needs review
StatusFileSize
new1.54 KB

Status: Needs review » Needs work

The last submitted patch, 3: testperf.search-SearchCommentTest.patch, failed testing.

sun’s picture

jhodgdon’s picture

Hm. The permission for the full HTML format is not working still with this patch. May need some kind of a cache clear after creating the format, to rebuild the permission names?

Ah, I see your other issue (cross-post as I was adding this comment). Sounds like we reached the same conclusion.

sun’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: testperf.search-SearchCommentTest.patch, failed testing.

jhodgdon’s picture

It looks like it's now failing on:

    // Enable check_plain() for 'Basic HTML' text format.
    $basic_html_format_id = 'basic_html';
    $edit = array(
      'filters[filter_html_escape][status]' => TRUE,
    );

It looks like the test is also relying on the "Basic HTML" format being present. In the Standard install profile, this format is defined, is automatically set up for any anonymous/authenticated user to use, and is the default text format. So I guess we'll need to set it up like this, and give the test user permission to use it.

Or... maybe just leave this using the Standard install profile?

sun’s picture

Status: Needs work » Needs review
StatusFileSize
new6.02 KB
new4.52 KB
sun’s picture

StatusFileSize
new5.63 KB

Victory! :-) Now without the run-tests.sh tweak.

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Great! Thanks sun! I've reviewed all the test changes, and they all look good to me.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit 6ae2108 on 8.x by catch:
    Issue #2254197 by sun: Fix test performance of Drupal\search\Tests\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.