Comments

tompagabor’s picture

Delete empty classes and row color is OK.

The error and warning table rows has got background colors. It is set in system.theme.css, and also used by status/warning/error messages. See the screenshot. And when hover, it's get the light blue bg.
table.system-status-report tr.ok:not(:hover) {background-color: transparent;}, used to hide that color, but table row can use the table hover color, as excpected the styleguide.

Please help to decide, which style is better.

tompagabor’s picture

Status: Active » Needs review
StatusFileSize
new1.77 KB

OK, i made a patch, where i moved styles to the seven stylesheet, from core.
Delete empty classes.

Set transparent background on error/warning/ok rows, but in a sorthen way.

Bojhan’s picture

Issue tags: +frontend
lewisnyman’s picture

Issue tags: +CSS

emma.maria’s picture

Status: Needs review » Needs work

The patch no longer applies as styles.css has been moved into the CSS folder since the patch was made. Not sure if this means a reroll or the patch being manually adjusted as files have moved around in.

tompagabor’s picture

StatusFileSize
new1.27 KB

Thank you for noticing! Updated.
Removed .hide-text class, because it not used anymore on status report page.

tompagabor’s picture

Status: Needs work » Needs review

Status update.

tompagabor’s picture

StatusFileSize
new1.4 KB

One more change: remove border from left and right side of the table.

emma.maria’s picture

Can you upload a patch file? Your files have .txt extenstions and then I will review it :)

tompagabor’s picture

StatusFileSize
new1.4 KB

Thanks Emma!

lewisnyman’s picture

Status: Needs review » Needs work

I think we should just remove the colours in system.theme.css instead of overriding the colours in Seven. There's no benefit in keeping those colours in Stark.

lewisnyman’s picture

Also, reading through the old issue, I think we should keep the background colours for error and warning but not for ok.

emma.maria’s picture

Assigned: Unassigned » emma.maria
emma.maria’s picture

Issue tags: +Needs accessibility review
StatusFileSize
new243.21 KB
new225.32 KB
new227.95 KB
new1.53 KB

Overview of work.

Changes to Seven
Matched the Status Report to the Seven style guide (spacing and borders), the /admin/structure type layout (spacing and borders) and the Messages styling (icon spacing)

Changes to system theme CSS:
Removed the OK green styling because of the decision at the end of the mother issue #665790: Redesign the status report page.

Screenshot of Seven

As I removed something from system theme css here are screenshots of Bartik and Stark for good measure.

Screenshot of Stark

Screenshot of Bartik

emma.maria’s picture

Status: Needs work » Needs review
Bojhan’s picture

Looks good to me!

herom’s picture

Status: Needs review » Needs work
+++ b/core/themes/seven/css/components/tables.css
@@ -1,4 +1,4 @@
+f/**

What is that "f" thing there? :)

emma.maria’s picture

Erm.... I will remove the f and an extra line space I just noticed somewhere else.

emma.maria’s picture

Assigned: emma.maria » Unassigned
Status: Needs work » Needs review
StatusFileSize
new1.52 KB
new523 bytes

New patch with mistakes corrected and an interdiff.

lewisnyman’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs accessibility review

Great, really happy with the row colours and the hover behaviour.

We already use these colours together in Seven so we don't need to assess the accessibility again.

yoroy’s picture

Oooh, lovely. Yes please.

emma.maria’s picture

Issue tags: +Amsterdam2014

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 20: 2227401-statusreport-20.patch, failed testing.

herom’s picture

Status: Needs work » Reviewed & tested by the community

HEAD was broken. back to rtbc.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 20: 2227401-statusreport-20.patch, failed testing.

emma.maria’s picture

Status: Needs work » Reviewed & tested by the community

Testbot was broken last night, back to RTBC

rootwork’s picture

Sure, sure, everything is broken, it's not the patch... ;)

emma.maria’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new617 bytes
new1.48 KB
new279.07 KB
new282.96 KB

So it turns out there are two places the table row colours are declared and the old colours are stronger selectors than the Seven Styleguide colours.

I have removed the old colours with the over specific CSS selectors, the rest of the patch is still the same.

Screenshots show table rows for error and warning, using styles shared with messages (that have the Seven Styleguide colours in place).

Status: Needs review » Needs work

The last submitted patch, 31: 2227401-statusreport-31.patch, failed testing.

lewisnyman’s picture

StatusFileSize
new589.38 KB

At the moment the hover blue replaces the background styling for error and warning rows. This looks bad. Can we update the CSS so the red/yellow colours stay?

Aleksandar_P’s picture

Status: Needs work » Needs review
StatusFileSize
new150.75 KB
new160.18 KB

In the following screenshot, you can see that the hover effect is not working neither on warning nor error rows since the background color stays yellow and read once they are hovered.

yoroy’s picture

That's intentionally, see comment #33

Aleksandar_P’s picture

I am not sure I understand what is the issue. Can you explain it please?

yoroy’s picture

Status: Needs review » Needs work

Hmm, tested the latest patch with simplytest.me and I see that the hover effect *does* get applied to warning messages. I think this needs work to exclude errors and messages from the hover effect.

Aleksandar_P’s picture

Status: Needs work » Needs review
StatusFileSize
new419 bytes
new419 bytes
new155.4 KB
new155.29 KB

I added the .info class to existing tr:hover and tr:focus since the hover effect has to be applied only to the rows with that class.

lauriii’s picture

Status: Needs review » Needs work

It seems like we are missing some changes from the latest patch

lewisnyman’s picture

Also, it would be problematic to add that class because it would affect normal tables. I think we just need some styling added to the warning and error row classes so they override the hover styling

emma.maria’s picture

Assigned: Unassigned » emma.maria
emma.maria’s picture

I have created a new patch based off of #31 with added selectors to keep the error and warning rows red and yellow when you hover over them.

Here's a quick screenshot...

emma.maria’s picture

Assigned: emma.maria » Unassigned
Status: Needs work » Needs review
lewisnyman’s picture

Status: Needs review » Reviewed & tested by the community

Yep, the hover styling no longer appears on the error and warning rows. Good work everyone

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

This issue is an unfrozen change (css) as per https://www.drupal.org/core/beta-changes and it's benefits outweigh any disruption. Committed c58599c and pushed to 8.0.x. Thanks!

  • alexpott committed c58599c on 8.0.x
    Issue #2227401 by emma.maria, tompagabor, Aleksandar_P | LewisNyman:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.