Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
27 Mar 2014 at 14:48 UTC
Updated:
24 Nov 2014 at 06:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tompagabor commentedDelete empty classes and row color is OK.
The error and warning table rows has got background colors. It is set in system.theme.css, and also used by status/warning/error messages. See the screenshot. And when hover, it's get the light blue bg.
table.system-status-report tr.ok:not(:hover) {background-color: transparent;}, used to hide that color, but table row can use the table hover color, as excpected the styleguide.Please help to decide, which style is better.
Comment #2
tompagabor commentedOK, i made a patch, where i moved styles to the seven stylesheet, from core.
Delete empty classes.
Set transparent background on error/warning/ok rows, but in a sorthen way.
Comment #3
Bojhan commentedComment #4
lewisnymanComment #6
emma.mariaThe patch no longer applies as styles.css has been moved into the CSS folder since the patch was made. Not sure if this means a reroll or the patch being manually adjusted as files have moved around in.
Comment #7
tompagabor commentedThank you for noticing! Updated.
Removed .hide-text class, because it not used anymore on status report page.
Comment #8
tompagabor commentedStatus update.
Comment #9
tompagabor commentedOne more change: remove border from left and right side of the table.
Comment #10
emma.mariaCan you upload a patch file? Your files have .txt extenstions and then I will review it :)
Comment #11
tompagabor commentedThanks Emma!
Comment #12
lewisnymanI think we should just remove the colours in system.theme.css instead of overriding the colours in Seven. There's no benefit in keeping those colours in Stark.
Comment #13
lewisnymanAlso, reading through the old issue, I think we should keep the background colours for error and warning but not for ok.
Comment #14
emma.mariaComment #15
emma.mariaOverview of work.
Changes to Seven
Matched the Status Report to the Seven style guide (spacing and borders), the /admin/structure type layout (spacing and borders) and the Messages styling (icon spacing)
Changes to system theme CSS:
Removed the OK green styling because of the decision at the end of the mother issue #665790: Redesign the status report page.
Screenshot of Seven

As I removed something from system theme css here are screenshots of Bartik and Stark for good measure.
Screenshot of Stark

Screenshot of Bartik

Comment #16
emma.mariaComment #17
Bojhan commentedLooks good to me!
Comment #18
herom commentedWhat is that "f" thing there? :)
Comment #19
emma.mariaErm.... I will remove the f and an extra line space I just noticed somewhere else.
Comment #20
emma.mariaNew patch with mistakes corrected and an interdiff.
Comment #21
lewisnymanGreat, really happy with the row colours and the hover behaviour.
We already use these colours together in Seven so we don't need to assess the accessibility again.
Comment #22
yoroy commentedOooh, lovely. Yes please.
Comment #23
emma.mariaComment #26
herom commentedHEAD was broken. back to rtbc.
Comment #29
emma.mariaTestbot was broken last night, back to RTBC
Comment #30
rootworkSure, sure, everything is broken, it's not the patch... ;)
Comment #31
emma.mariaSo it turns out there are two places the table row colours are declared and the old colours are stronger selectors than the Seven Styleguide colours.
I have removed the old colours with the over specific CSS selectors, the rest of the patch is still the same.
Screenshots show table rows for error and warning, using styles shared with messages (that have the Seven Styleguide colours in place).


Comment #33
lewisnymanAt the moment the hover blue replaces the background styling for error and warning rows. This looks bad. Can we update the CSS so the red/yellow colours stay?

Comment #35
Aleksandar_P commentedIn the following screenshot, you can see that the hover effect is not working neither on warning nor error rows since the background color stays yellow and read once they are hovered.
Comment #36
yoroy commentedThat's intentionally, see comment #33
Comment #37
Aleksandar_P commentedI am not sure I understand what is the issue. Can you explain it please?
Comment #38
yoroy commentedHmm, tested the latest patch with simplytest.me and I see that the hover effect *does* get applied to warning messages. I think this needs work to exclude errors and messages from the hover effect.
Comment #39
Aleksandar_P commentedI added the .info class to existing tr:hover and tr:focus since the hover effect has to be applied only to the rows with that class.
Comment #40
lauriiiIt seems like we are missing some changes from the latest patch
Comment #41
lewisnymanAlso, it would be problematic to add that class because it would affect normal tables. I think we just need some styling added to the warning and error row classes so they override the hover styling
Comment #42
emma.mariaComment #43
emma.mariaI have created a new patch based off of #31 with added selectors to keep the error and warning rows red and yellow when you hover over them.
Here's a quick screenshot...

Comment #44
emma.mariaComment #45
lewisnymanYep, the hover styling no longer appears on the error and warning rows. Good work everyone
Comment #46
alexpottThis issue is an unfrozen change (css) as per https://www.drupal.org/core/beta-changes and it's benefits outweigh any disruption. Committed c58599c and pushed to 8.0.x. Thanks!