Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
routing system
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 Mar 2014 at 12:16 UTC
Updated:
29 Jul 2014 at 23:28 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
swentel commentedThis is one approach, not sure whether it's the right one.
Still need admin/content though
Comment #2
longwaveAdminRouteSubscriber already sets _admin_route to TRUE on all admin/* paths, it just needs reordering so it runs after Field UI's and Views' own route subscribers.
Comment #3
longwaveNot sure about the -200, I picked it arbitrarily as Field UI's subscriber uses -100.
Comment #4
dawehnerIt seems fine to have that low number as long we have some little bit of documentation to actually know why it is done in that particular way.
Comment #5
swentel commentedYes, this is more sane indeed. Both are now in the admin interface.
Comment #6
andypostso only views part (admin/content) left here?
Comment #7
swentel commentedHmm don't think so, quickly tested it and it was ok, maybe someone else should reverify.
Comment #8
andypostWorks for me!
Comment #9
longwaveAdminRouteSubscriber runs after \Drupal\views\EventSubscriber\RouteSubscriber so Views routes such as /admin/content are included.
We might want a separate Views page display option for "Use admin theme" but that is outside the scope of this issue.
Comment #10
catchAdded a @todo pointing to #2158571: Routes added in RouteSubscribers cannot be altered, this shouldn't be necessary if we have separate add/alter stages. Attaching interdiff.
Committed/pushed to 8.x, thanks!