Comments

swentel’s picture

Status: Active » Needs review
StatusFileSize
new3.4 KB

This is one approach, not sure whether it's the right one.
Still need admin/content though

longwave’s picture

StatusFileSize
new908 bytes

AdminRouteSubscriber already sets _admin_route to TRUE on all admin/* paths, it just needs reordering so it runs after Field UI's and Views' own route subscribers.

longwave’s picture

Not sure about the -200, I picked it arbitrarily as Field UI's subscriber uses -100.

dawehner’s picture

It seems fine to have that low number as long we have some little bit of documentation to actually know why it is done in that particular way.

swentel’s picture

Yes, this is more sane indeed. Both are now in the admin interface.

andypost’s picture

Issue tags: +VDC

so only views part (admin/content) left here?

swentel’s picture

Hmm don't think so, quickly tested it and it was ok, maybe someone else should reverify.

andypost’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -VDC

Works for me!

longwave’s picture

Issue tags: +VDC
StatusFileSize
new1.07 KB

AdminRouteSubscriber runs after \Drupal\views\EventSubscriber\RouteSubscriber so Views routes such as /admin/content are included.

We might want a separate Views page display option for "Use admin theme" but that is outside the scope of this issue.

catch’s picture

Status: Reviewed & tested by the community » Fixed
StatusFileSize
new760 bytes

Added a @todo pointing to #2158571: Routes added in RouteSubscribers cannot be altered, this shouldn't be necessary if we have separate add/alter stages. Attaching interdiff.

Committed/pushed to 8.x, thanks!

  • Commit f4b1b35 on 8.x by catch:
    Issue #2224553 by longwave, swentel: Add _admin_route for field manager...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.