Move drupalRender() and drupalRenderCollectCacheTags() out of HtmlControllerBase

This was certainly just a freakout from crell :)

If we manage to put drupal_render/drupal_render_collect_cache_tags into a service we will do it, otherwise the current pattern is the way to move forward.

Closing as per #1.

There is a reference to this issue in AjaxRenderer, at least we should remove that reference.

+1

Done.
Should we replace the deprecated method too?

I think the right fix is to actually convert drupal_render_root() to the renderer service.

For #6.

Fixed.

+++ b/core/lib/Drupal/Core/Render/MainContent/AjaxRenderer.php
@@ -76,11 +76,9 @@ public function renderResponse(array $main_content, Request $request, RouteMatch
-    return drupal_render_root($elements);
+    return \Drupal::service('renderer')->renderRoot($elements);

Thanks, this is a good step forward!

It's not quite done yet though: we want to have the '@renderer' service injected into this service (so that it is passed into this class' constructor). Then we can remove drupalRenderRoot() altogether, and just call $this->renderer->renderRoot()!

Here's a patch that injects the renderer service, and also removes the drupalRenderRoot() method.

Is there a reason we cannot close this issue as duplicate of #2818677: Replace usages of deprecated method drupal_render_root()?

> Is there a reason we cannot close this issue as duplicate of #2818677: Replace usages of deprecated method drupal_render_root()?

No reason.