$path in hook_help should contain '%' wildcard for paths with parameters, but it actually contains the raw path (e.g. node/1/revisions instead of node/%/revisions).

This is an example from node_help (the rest can be found with this grep -rn "case '.*%.*':"):

    case 'node/%/revisions':
      return '<p>' . t('Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.') . '</p>';

so, the revisions page should contain that text, but now it doesn't.

CommentFileSizeAuthor
#2 hook_help_dynamic_routes-2180343-2.patch89.21 KBtvanro

Comments

larowlan’s picture

It should use route names, much simpler

tvanro’s picture

Status: Active » Needs review
Issue tags: +SprintWeekend2014
StatusFileSize
new89.21 KB

This isn't following larowlan's suggestion but it fixes the current problem and can be improved in a follow-up.

Status: Needs review » Needs work

The last submitted patch, 2: hook_help_dynamic_routes-2180343-2.patch, failed testing.

larowlan’s picture

herom’s picture

Status: Needs work » Closed (duplicate)

This seems to have been fixed by #2183113: Update hook_help signature to use route_name instead of path. closing as duplicate per #5.