$path in hook_help should contain '%' wildcard for paths with parameters, but it actually contains the raw path (e.g. node/1/revisions instead of node/%/revisions).
This is an example from node_help (the rest can be found with this grep -rn "case '.*%.*':"):
case 'node/%/revisions':
return '<p>' . t('Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.') . '</p>';
so, the revisions page should contain that text, but now it doesn't.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | hook_help_dynamic_routes-2180343-2.patch | 89.21 KB | tvanro |
Comments
Comment #1
larowlanIt should use route names, much simpler
Comment #2
tvanro commentedThis isn't following larowlan's suggestion but it fixes the current problem and can be improved in a follow-up.
Comment #4
larowlanRelated #2183113: Update hook_help signature to use route_name instead of path
Comment #5
jhodgdonThis is most likely a duplicate of either #244090: Tie help into menu router or #2183113: Update hook_help signature to use route_name instead of path?
Comment #6
herom commentedThis seems to have been fixed by #2183113: Update hook_help signature to use route_name instead of path. closing as duplicate per #5.