BlockAccessController::checkAccess() is not executed if any hook_block_access() returns data

Updated: Comment #0

Problem/Motivation

After custom block is placed in some region with "node condition" there's no way to remove or reconfigure one.
That's caused by EntityListController::getOperations() code

    if ($entity->access('update')) {
      $operations['edit'] = array(
        'title' => $this->t('Edit'),
        'href' => $uri['path'] . '/edit',
        'options' => $uri['options'],
        'weight' => 10,
      );
    }

User could not have access to update/delete a custom block because node_block_access() fires first and blocks execution of entity access callback in EntityAccessController::access()

    $access = array_merge(
      $this->moduleHandler->invokeAll('entity_access', array($entity, $operation, $account, $langcode)),
      $this->moduleHandler->invokeAll($entity->entityType() . '_access', array($entity, $operation, $account, $langcode))
    );

    if (($return = $this->processAccessHookResults($access)) === NULL) {
      // No module had an opinion about the access, so let's the access
      // controller check create access.
      $return = (bool) $this->checkAccess($entity, $operation, $langcode, $account);
    }
    return $this->setCache($return, $entity->uuid(), $operation, $langcode, $account);

The comment makes sense so ...

Proposed resolution

Use BlockListController::access() method to fire it before standard controller

Remaining tasks

tbd

User interface changes

UI should work

API changes

not sure