
This is a very simple change; I hoped we can get rid of the whole of Doctrine Commons but as we use Reflection, we can't alas. Still, for easier review, attached is the composer.json change separately. The patch contains the results of composer update doctrine/annotations
.
The relevant grammar was:
Annotation ::= "@" AnnotationName ["(" [Values] ")"]
Values ::= Array | Value {"," Value}*
Now we have
Annotation ::= "@" AnnotationName MethodCall
MethodCall ::= ["(" [Values] ")"]
Values ::= Array | Value {"," Value}* [","]
Comment | File | Size | Author |
---|---|---|---|
#6 | 2138867_4.patch | 41.59 KB | chx |
#4 | trailing_commas_review.txt | 428 bytes | chx |
Comments
Comment #1
tim.plunkettFor those following along, this is a result of https://github.com/doctrine/annotations/pull/11
I say +1 to this, if we want the rest of doctrine back later we can add it in, that's the beauty of composer.
Comment #3
chx CreditAttribution: chx commentedComment #4
chx CreditAttribution: chx commentedComment #5
tim.plunkettA little less hasty with my RTBC this time, if this passes I'll be back for it.
Comment #6
chx CreditAttribution: chx commentedtimplunkett tells me not to upgrade Doctrine Commons itself. Sure.
Comment #7
chx CreditAttribution: chx commentedComment #8
tim.plunkettAnnnnddddd passing.
Comment #9
webchickOne of my top, like, 6 patches of all time. :)
Committed and pushed to 8.x. YEAH!
Comment #10
webchickRetroactively tagging.