Hal Entity Normalizer assumes bundle key is always 'type'

Related: #1867228: Make EntityTypeManager provide an entity factory and #1892320: Add deserialize for JSON/AJAX

Yes, patch berdir mentions above already does this approach, so it's good they are aligned.

Tests - it looks like there are no tests at all for denormalizing of entities so not sure where to put them.

I'm not sure I understand correctly. What about DenormalizeTest?

That's what I was thinking! :)

3: entity-normalizer.patch queued for re-testing.

Let's start this again. The above patch does not apply anymore, but pretty much none of it is the same anymore, since we now inject the deps into these services. Also making the change to inject module handler while we are changing the constructors..

Let's get this ok again, then maybe add a test case for this.

Looks good.

A test could be done by adding a test using terms similar to NodeTest? that explodes right now if you try to denormalize it.

maybe also unset the type from $data then, to avoid setting it twice, similar to the langcode in the ConfigField issue?

I have added the unset for the bundle in $data, that makes alot of sense :)

Do we need to add an additional test for this, the fact that we have made these changes to handle the bundle name generically and our current tests work cover this?

I think we do, given the amount of broken things in hal, I wouldn't be surprised if more about terms is broken :)

That said, I'm adding tests for normalizing nodes and terms and back in #2219795: Config entity references broken and other bugs, do we want to merge the patches maybe? There's also @yched's issue about simplfying the field normalizer classes further than I did referenced there, we could merge that in too. Would make it easy to get that stuff in with proper test coverage, although the patches are getting bigger...

Ok, the latest patch is now in #2219795: Config entity references broken and other bugs, which made that pass :)