Variable to config: tracker.settings [d7]

working on this.

Tracker in D8 has cron_index_limit but in D6 doesn't have any variable. That should we do here?

A quick grep verifies, yes, there is no variable_get in tracker.

One would wonder why are we going by the update_variables_to_config() calls, then? We do not have anything to better to go by and most variables didn't change.

Moving to the core queue to consolidate issues now that we're doing all the work there.

Working on this.

First Drupal.org patch, after reading through the Patch Guide I believe this is the correct format.

One question I had, should I use:

+    ->values(array(
+      'name' => 'cron_index_limit',
+      'value' => serialize(1000),
+    ))

OR

+    ->values(array(
+      'name' => 'cron_index_limit',
+      'value' => 'i:1000;',
+    ))

To serialize? Looking at the D6 migration values they use option 2, looking at the D7 migration values they use serialize().

It's really a mix of the two -- if youd dump with a script you get serialized data but we convert more complex data structures back to serialized arrays for the sake of readibility. So for a simple integer, just i: is fine.

1. +++ b/core/modules/migrate_drupal/config/migrate.migration.d7_tracker_settings.yml
   @@ -0,0 +1,10 @@
   +    plugin: drupal6_variable
   +    variables:
   

   Indentation needs to be 2 space.

2. +++ b/core/modules/migrate_drupal/lib/Drupal/migrate_drupal/Tests/d7/MigrateTrackerConfigsTest.php
   @@ -0,0 +1,52 @@
   + * Contains \Drupal\migrate_drupal\Tests\d7\MigrateTrackerSettingsTest.
   

   This should be the same as the class name.

3. +++ b/core/modules/migrate_drupal/lib/Drupal/migrate_drupal/Tests/d7/MigrateTrackerConfigsTest.php
   @@ -0,0 +1,52 @@
   +class MigrateTrackerConfigsTest extends MigrateDrupalTestBase {
   

   I think MigrateTrackerConfigTest reads better?

Above are just small doc changes, great job for your first patch.

Side note, It's strange that we're using d6_variable as our source? I know they're functionally equivalent but we should probably look at creating a base class with d6/7 sub classes.

Thanks chx, I've changed the code not to use serialize.

benjy - thanks for the review.

If we want to change file from "MigrateTrackerConfigTest.php", the parent issue (https://drupal.org/node/2181257) will need to be updated to change point 4.

Patch fixes variable indents and uses 'config' instead of d8_config

1. +++ b/core/modules/migrate_drupal/config/migrate.migration.d7_tracker_settings.yml
   @@ -0,0 +1,10 @@
   \ No newline at end of file
   

   We need an empty line at the end of the file.

2. +++ b/core/modules/migrate_drupal/lib/Drupal/migrate_drupal/Tests/d7/MigrateTrackerConfigTest.php
   @@ -0,0 +1,52 @@
   +    $executable = new MigrateExecutable($migration, new MigrateMessage());
   

   Replace new MigrateMessage() with $this because the migration implements MigrateMessageInterface

Fixed newline and MigrateMessage

ignore

Committed to 8.x j9689f36

Will need to be submitted again to Core since moving from sandbox.

Needs to be merged into the parent issue.

Duplicate of #2353777: Migrate Tracker module variables in D7. I'll give @joshtaylor credit in that issue.