Variable to config: filter.settings [D7 only]

working on this.

Attach the patch. I only found a one variable to map. The problem is that drupal 6 has two default format and d8 not.

As discussed on IRC: this is D7.

Working on this

First try for filter settings on D7. The filter.settings.yml has a second variable (always_show_fallback_choice) but I think it doesn't have a mapping from D7, so I haven't included it.

I have tried rerolling this. Patch attached.
The tests aren't working on my local, output attached. Want to see if it's just me.
The output complains when this gets called.

Drupal\migrate\Entity\Migration->getProcessNormalized('fallback_format:filter_fallback_format')

it says

Argument 1 passed to Drupal\migrate\Entity\Migration::getProcessNormalized()
must be of the type array, string given

but I can't work out where I have gone wrong.

EDIT: a reinstall fixed it. The value fallback_format:filter_fallback_format was being cached.
In d7_filter_settings.yml a space is needed after the colon in "d7_filter_settings.yml"

Here's the patch with the missing space after the colon added.

+++ b/core/modules/migrate_drupal/lib/Drupal/migrate_drupal/Tests/d7/MigrateFilterFormatsTest.php
@@ -0,0 +1,49 @@
+ * @file
+ * Contains \Drupal\migrate_drupal\Tests\d7\MigrateFilterFormats.
+ */

Shouldn't this be Drupal\migrate_drupal\Tests\d7\MigrateFilterFormatsTest ?

The rest of the patch looks correct and the tests are passing.

Thanks David. Sorry for not getting to this. Confirming the fix to the comment.

Will need to be submitted again to Core since moving from sandbox.

This patch should be updated for HEAD and merged into the parent issue.

Zero-byte patch?!?

Re-rolled.

Changed test group.

Re-rollin'.

Filter settings are soon to be container parameters (#2529514: Replace system.filter::protocols with container parameters), so this needs to be rewritten for that.

Here's the reroll

@alvar0hurtad0, thx for the reroll. The migrations have moved to the individual modules. So this goes to the filter module. There is an existing migration there, d7_filter_format, that can be used for reference.

+++ b/core/modules/migrate_drupal/src/Tests/d7/MigrateFilterSettingsTest.php
@@ -0,0 +1,36 @@
+    $this->loadDumps(['Variable.php']);

Can be removed. The test fixture is loaded in the parent.

+++ b/core/modules/migrate_drupal/migration_templates/d7_filter_settings.yml
@@ -0,0 +1,17 @@
+dependencies:
+  module:
+    - filter
+    - migrate_drupal

This shouldn't be needed either.

Comments given in #27 sounds novice.

Adding patch.

We'll today check why tests are failing.

Move files to correct locations.

Self-assigning for review.

+++ b/core/modules/filter/tests/src/Kernel/Migrate/d7/MigrateFilterSettingsTest.php
@@ -0,0 +1,32 @@
+    $this->assertSame('plain_text', \Drupal::config('filter.settings')->get('fallback_format'));

This should use $this->config() rather than \Drupal::config().

Otherwise, looks good.

Use $this->config() rather than \Drupal::config().

Looks good, thanks!

Committed/pushed to 8.3.x and cherry-picked to 8.2.x. Thanks!