The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Specific language code is unnecessary for link to PHP Manual. It will lead to their language page, if specific language code is not specified.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | php.net-manual.patch | 6.32 KB | lilou |
| #3 | PATCH_HEAD_AUG_26_2008---SYSLOG_INCLUDES_LOCALIZED_URL---ROBIN_MONKS.patch | 2.61 KB | robin monks |
| syslog.patch.txt | 3.63 KB | Takafumi |
Comments
Comment #1
keith.smith commentedBoth the current and the proposed new links work ok for me, and return what appears to be the same page. I'm sure there is some difference between them, but I don't immediately notice what it is.
@Takafumi: Can you elaborate on why the new string is necessary given that changing the link will invalidate the string for translators?
Comment #2
Takafumi commentedWhen accessing to manual/en/foo, page will be displayed in English.
But, if accessing to manual/foo, page will be automatically redirected, and be displayed in visitor's language(HTTP_ACCEPT_LANGUAGE).
Comment #3
robin monks commentedThis issue still exists in HEAD. I doubt it would be backported to 6.x due to translation issues, but +1 on getting this fixed for 7.x.
Re-rolled this patch for 7.x, requesting review.
Robin
Comment #4
lilou commentedAffected files :
modules/color/color.installmodules/color/color.modulemodules/syslog/syslog.modulesites/default/default.settings.phpComment #5
robin monks commentedApplied clean and everything looks good.
RTBC!
Robin
Comment #6
dries commentedCommitted to CVS HEAD. Thanks.
Comment #7
robin monks commentedThanks Dries!
Comment #8
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.