Update hook_help for Tracker module

I'll edit this.

Some urls edited in the help text.

Just noticed a url issue, re-submitting.

I could not update it according to D8 docs standards because function tracker_help (file: tracker.module) has inside :

... array('!recent' => url('tracker'))...

and module tracker has no file tracker.routing.yml. Therefore I could not convert old url to new one.

My previous comment is deprecated. I had no page refreshed. I am sorry.

I checked it. It works right.

The Uses section is not following our standards for hook_help() - the headings should be -ing actions. So instead of "Tracking navigation", maybe the heading should be "Viewing the recent content list" or something like that? ... Actually, the topic really seems to be about the menu item and not about what is on the page, so probably this heading needs to reflect that. Probably it shouldn't be first in the list either -- it doesn't seem like the most important task to document?

Also, we need to convert url('admin/structure/menu')) to use the new routes format for URLs. This is not in the Tracker module -- it's from the Menu Links module I think? I am not sure why tracker is still using hook_menu() instead of a routing.yml file... that's very odd. Oh, it's in progress:
#1972990: Convert tracker_page() to a Controller
So probably we should postpone finishing this issue until that other one is completed.

Looks like the issue that was postponing this has been resolved.

This patch fixes the urls

I didnt find that whole Navigation point very informative, so I removed it

The help text mentions a user specific tracking page ("To follow a specific user's new and updated content, select the <em>Track</em> tab from the user's profile page.") that would be accessible from the account page. But the account page has no Track tab. At least not in my local D8 install. There does exist a route in tracker.routing.yml

I assign it to the tracker.module component in hope to get some feedback

That test failure is a random test problem, see:
#2157927: Intermittent test fails in LocaleUpdateTest::testUpdateImportSourceRemote()
and it would be good NOT to click Retest on it so we can keep the test run report around. If you want a retest, please instead upload a new patch file.

So I think the latest patch is fine, but we need input from the tracker.module maintainers about the tabs and the intent there.

I have tested it on my local and has not given errors. So I repeat the tests.

9: update-hook-help-tracker-2091429-9.patch queued for re-testing.

I had asked for retest not to be submitted. Oh well. :)

David Strauss: As the maintainer for the Tracker module, we need your input -- see comment #9.

We just had a change to hook_help, on this issue: #2183113: Update hook_help signature to use route_name instead of path.

Here is the change record: https://drupal.org/node/2250345

This patch will need a reroll for this change.

DAVID STRAUSS: If you are maintaining Tracker... We asked for your input on April 1st. Please respond. Thanks!

The changes look good, at least in the sense of using the new API and not introducing regressions. So, +1 on committing.

However, we could use this as an opportunity to clean up the help lines in general. The "To follow a specific user's new and updated content" line in the patch context should move back to single quotes, given that it doesn't contain any single-quoted content. I'm also curious why "<a href='!recent'>" uses single quotes for the href value, given that the HTML standard (or at least norm) is to use double quotes.

David: Thanks for responding!

Good idea to fix up the help as you suggested. I also forgot to set it to "needs work" due to #16.

@jhodgdon - Please review attached patch which can be successfully applied in current code. The #9 patch doesn't work with the current code.

Changes suggested in #17 are not relevant.

1) The "To follow a specific user's new and updated content" line in the patch context should move back to single quotes, given that it doesn't contain any single-quoted content.

It contains single-quoted content, user's.

2) I'm also curious why "" uses single quotes for the href value, given that the HTML standard (or at least norm) is to use double quotes.

As the section content is in double quotes in t() function so the '!recent' in href is in single quotes.

@David Strauss - We asked a specific question in #9 about the Track page from the User account. Can you please respond?

Regarding #19, we should always use double quotes in href="" and other HTML attributes. This may mean that the patch needs to change t('') to use single quotes, and if there are apostrophes in the text, they can be escaped like

t('The user\'s tracker page...

@jhodgdon - I have updated the patch as per the single / double quotes suggestion in #20.

Please review.

We still need an answer for #9 before we can proceed in this patch, I think?

Anyway, the single/double quotes in the latest patch look good.

@jhodgdon - Track tab is visible on user account page. Please see attached screenshot for reference.

Oh good, thanks! I had not tested, was just asking for clarification based on previous comments.

In that case, this help looks good to me, and it is ready for a manual test:
- Verify that all the links work
- Verify that all mentions of pages/text/permissions within the UI match what is seen in the UI
- Verify that the formatting is OK.

whoops, copy/paste error

Looks like @David Strauss forgot to unassign it...

... I can help review it though!

Code looks good.

Manual testing shows all the links work and the terminology appears to be consistent with the rest of the help pages.

Thanks again everyone! Committed to 8.x.